Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Ensures display rotation triggers PiP re-position" into rvc-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2020-02-27 02:39:05 +00:00
committed by Android (Google) Code Review
parent ee47af6207 bede2c1049
commit abe2fed8b0
3 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/SystemUI/src/com/android/systemui/pip/phone/PipManager.java
View File

@@ -341,7 +341,10 @@ public class PipManager implements BasePipManager, PipTaskOrganizer.PipTransitio
private void updateMovementBounds(Rect animatingBounds, boolean fromImeAdjustment, private void updateMovementBounds(Rect animatingBounds, boolean fromImeAdjustment,
boolean fromShelfAdjustment) { boolean fromShelfAdjustment) {
// Populate inset / normal bounds and DisplayInfo from mPipBoundsHandler first. mPipTaskOrganizer.onDisplayInfoChanged(mTmpDisplayInfo);
// Populate inset / normal bounds and DisplayInfo from mPipBoundsHandler before
// passing to mTouchHandler, mTouchHandler would rely on the bounds calculated by
// mPipBoundsHandler with up-to-dated information
mPipBoundsHandler.onMovementBoundsChanged(mTmpInsetBounds, mTmpNormalBounds, mPipBoundsHandler.onMovementBoundsChanged(mTmpInsetBounds, mTmpNormalBounds,
animatingBounds, mTmpDisplayInfo); animatingBounds, mTmpDisplayInfo);
mTouchHandler.onMovementBoundsChanged(mTmpInsetBounds, mTmpNormalBounds, mTouchHandler.onMovementBoundsChanged(mTmpInsetBounds, mTmpNormalBounds,

4
packages/SystemUI/src/com/android/systemui/pip/phone/PipMotionHelper.java
View File

@@ -411,11 +411,9 @@ public class PipMotionHelper implements Handler.Callback, PipAppOpsListener.Call
} }
private void adjustAndAnimatePipOffset(Rect originalBounds, int offset, int duration) { private void adjustAndAnimatePipOffset(Rect originalBounds, int offset, int duration) {
if (offset == 0) {
return;
}
SomeArgs args = SomeArgs.obtain(); SomeArgs args = SomeArgs.obtain();
args.arg1 = originalBounds; args.arg1 = originalBounds;
// offset would be zero if triggered from screen rotation.
args.argi1 = offset; args.argi1 = offset;
args.argi2 = duration; args.argi2 = duration;
mHandler.sendMessage(mHandler.obtainMessage(MSG_OFFSET_ANIMATE, args)); mHandler.sendMessage(mHandler.obtainMessage(MSG_OFFSET_ANIMATE, args));

6
packages/SystemUI/src/com/android/systemui/pip/phone/PipTouchHandler.java
View File

@@ -269,6 +269,10 @@ public class PipTouchHandler {
public void onMovementBoundsChanged(Rect insetBounds, Rect normalBounds, Rect curBounds, public void onMovementBoundsChanged(Rect insetBounds, Rect normalBounds, Rect curBounds,
boolean fromImeAdjustment, boolean fromShelfAdjustment, int displayRotation) { boolean fromImeAdjustment, boolean fromShelfAdjustment, int displayRotation) {
final int bottomOffset = mIsImeShowing ? mImeHeight : 0; final int bottomOffset = mIsImeShowing ? mImeHeight : 0;
final boolean fromDisplayRotationChanged = (mDisplayRotation != displayRotation);
if (fromDisplayRotationChanged) {
mTouchState.reset();
}
// Re-calculate the expanded bounds // Re-calculate the expanded bounds
mNormalBounds = normalBounds; mNormalBounds = normalBounds;
@@ -296,7 +300,7 @@ public class PipTouchHandler {
// If this is from an IME or shelf adjustment, then we should move the PiP so that it is not // If this is from an IME or shelf adjustment, then we should move the PiP so that it is not
// occluded by the IME or shelf. // occluded by the IME or shelf.
if (fromImeAdjustment || fromShelfAdjustment) { if (fromImeAdjustment || fromShelfAdjustment || fromDisplayRotationChanged) {
if (mTouchState.isUserInteracting()) { if (mTouchState.isUserInteracting()) {
// Defer the update of the current movement bounds until after the user finishes // Defer the update of the current movement bounds until after the user finishes
// touching the screen // touching the screen