From abc24090f0be2ab14bf373a4639c49a0bf7f3802 Mon Sep 17 00:00:00 2001 From: Evan Rosky Date: Wed, 5 May 2021 23:19:04 +0000 Subject: [PATCH] Revert "Add reporting to monitor apps incorrectly using getRaw" This reverts commit 8b820867220d07bf4a0e970ed1416bc8729fc9b7. Reason for revert: Metrics no-longer needed, we are adding compat for this. Bug: 187153492 Test: N/A Change-Id: I31bbe36378a2da969a094405b0e0a7b7b9cde3a0 --- core/java/android/hardware/input/InputManager.java | 8 -------- core/java/android/view/MotionEvent.java | 6 ------ 2 files changed, 14 deletions(-) diff --git a/core/java/android/hardware/input/InputManager.java b/core/java/android/hardware/input/InputManager.java index 51d196dc82928..17116e2486466 100644 --- a/core/java/android/hardware/input/InputManager.java +++ b/core/java/android/hardware/input/InputManager.java @@ -222,14 +222,6 @@ public final class InputManager { @ChangeId public static final long BLOCK_FLAG_SLIPPERY = android.os.IInputConstants.BLOCK_FLAG_SLIPPERY; - /** - * Check whether apps are using MotionEvent.getRawX/Y. This is implementation-specific, and - * thus undefined for most 3p app usages. - * @hide - */ - @ChangeId - public static final long APP_USES_RAW_INPUT_COORDS = 179274888L; - /** * Input Event Injection Synchronization Mode: None. * Never blocks. Injection is asynchronous and is assumed always to be successful. diff --git a/core/java/android/view/MotionEvent.java b/core/java/android/view/MotionEvent.java index 31ca8e124f9e7..6801c27851a9a 100644 --- a/core/java/android/view/MotionEvent.java +++ b/core/java/android/view/MotionEvent.java @@ -16,7 +16,6 @@ package android.view; -import static android.hardware.input.InputManager.APP_USES_RAW_INPUT_COORDS; import static android.view.Display.DEFAULT_DISPLAY; import static java.lang.annotation.RetentionPolicy.SOURCE; @@ -24,7 +23,6 @@ import static java.lang.annotation.RetentionPolicy.SOURCE; import android.annotation.IntDef; import android.annotation.Nullable; import android.annotation.TestApi; -import android.compat.Compatibility; import android.compat.annotation.UnsupportedAppUsage; import android.graphics.Matrix; import android.os.Build; @@ -2674,7 +2672,6 @@ public final class MotionEvent extends InputEvent implements Parcelable { * @see #AXIS_X */ public final float getRawX() { - Compatibility.reportUnconditionalChange(APP_USES_RAW_INPUT_COORDS); return nativeGetRawAxisValue(mNativePtr, AXIS_X, 0, HISTORY_CURRENT); } @@ -2688,7 +2685,6 @@ public final class MotionEvent extends InputEvent implements Parcelable { * @see #AXIS_Y */ public final float getRawY() { - Compatibility.reportUnconditionalChange(APP_USES_RAW_INPUT_COORDS); return nativeGetRawAxisValue(mNativePtr, AXIS_Y, 0, HISTORY_CURRENT); } @@ -2705,7 +2701,6 @@ public final class MotionEvent extends InputEvent implements Parcelable { * @see #AXIS_X */ public float getRawX(int pointerIndex) { - Compatibility.reportUnconditionalChange(APP_USES_RAW_INPUT_COORDS); return nativeGetRawAxisValue(mNativePtr, AXIS_X, pointerIndex, HISTORY_CURRENT); } @@ -2722,7 +2717,6 @@ public final class MotionEvent extends InputEvent implements Parcelable { * @see #AXIS_Y */ public float getRawY(int pointerIndex) { - Compatibility.reportUnconditionalChange(APP_USES_RAW_INPUT_COORDS); return nativeGetRawAxisValue(mNativePtr, AXIS_Y, pointerIndex, HISTORY_CURRENT); }