Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Dismiss lingering volume dialog" into udc-dev

Browse Source
This commit is contained in:
Behnam Heydarshahi
2023-05-23 13:46:45 +00:00
committed by Android (Google) Code Review
parent a940105294 06a390a1de
commit aba85c443c
1 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/SystemUI/src/com/android/systemui/volume/VolumeDialogImpl.java
View File

@@ -404,6 +404,7 @@ public class VolumeDialogImpl implements VolumeDialog, Dumpable,
@Override @Override
public void destroy() { public void destroy() {
Log.d(TAG, "destroy() called");
mController.removeCallback(mControllerCallbackH); mController.removeCallback(mControllerCallbackH);
mHandler.removeCallbacksAndMessages(null); mHandler.removeCallbacksAndMessages(null);
mConfigurationController.removeCallback(this); mConfigurationController.removeCallback(this);
@@ -465,6 +466,7 @@ public class VolumeDialogImpl implements VolumeDialog, Dumpable,
} }
private void initDialog(int lockTaskModeState) { private void initDialog(int lockTaskModeState) {
Log.d(TAG, "initDialog: called!");
mDialog = new CustomDialog(mContext); mDialog = new CustomDialog(mContext);
initDimens(); initDimens();
@@ -1269,7 +1271,7 @@ public class VolumeDialogImpl implements VolumeDialog, Dumpable,
} }
protected void tryToRemoveCaptionsTooltip() { protected void tryToRemoveCaptionsTooltip() {
if (mHasSeenODICaptionsTooltip && mODICaptionsTooltipView != null) { if (mHasSeenODICaptionsTooltip && mODICaptionsTooltipView != null && mDialog != null) {
ViewGroup container = mDialog.findViewById(R.id.volume_dialog_container); ViewGroup container = mDialog.findViewById(R.id.volume_dialog_container);
container.removeView(mODICaptionsTooltipView); container.removeView(mODICaptionsTooltipView);
mODICaptionsTooltipView = null; mODICaptionsTooltipView = null;
@@ -1476,8 +1478,16 @@ public class VolumeDialogImpl implements VolumeDialog, Dumpable,
mHandler.removeMessages(H.DISMISS); mHandler.removeMessages(H.DISMISS);
mHandler.removeMessages(H.SHOW); mHandler.removeMessages(H.SHOW);
if (mIsAnimatingDismiss) {
Log.d(TAG, "dismissH: isAnimatingDismiss"); boolean showingStateInconsistent = !mShowing && mDialog != null && mDialog.isShowing();
// If incorrectly assuming dialog is not showing, continue and make the state consistent.
if (showingStateInconsistent) {
Log.d(TAG, "dismissH: volume dialog possible in inconsistent state:"
+ "mShowing=" + mShowing + ", mDialog==null?" + (mDialog == null));
}
if (mIsAnimatingDismiss && !showingStateInconsistent) {
Log.d(TAG, "dismissH: skipping dismiss because isAnimatingDismiss is true"
+ " and showingStateInconsistent is false");
Trace.endSection(); Trace.endSection();
return; return;
} }
@@ -1495,8 +1505,12 @@ public class VolumeDialogImpl implements VolumeDialog, Dumpable,
.setDuration(mDialogHideAnimationDurationMs) .setDuration(mDialogHideAnimationDurationMs)
.setInterpolator(new SystemUIInterpolators.LogAccelerateInterpolator()) .setInterpolator(new SystemUIInterpolators.LogAccelerateInterpolator())
.withEndAction(() -> mHandler.postDelayed(() -> { .withEndAction(() -> mHandler.postDelayed(() -> {
mController.notifyVisible(false); if (mController != null) {
mDialog.dismiss(); mController.notifyVisible(false);
}
if (mDialog != null) {
mDialog.dismiss();
}
tryToRemoveCaptionsTooltip(); tryToRemoveCaptionsTooltip();
mIsAnimatingDismiss = false; mIsAnimatingDismiss = false;