From ab72367506bdc9ce97db4ce3714ff65cedfa5e05 Mon Sep 17 00:00:00 2001 From: Sergio Giro Date: Thu, 21 Jan 2016 15:25:01 +0000 Subject: [PATCH] org.apache.conn.ssl: rename DistinguishedNameParser to AndroidDistinguishedNameParser The name DistinguishedNameParser is used by other libraries having the same package, and some apps incorrectly include packages that are present in the boot classpath. This relatively newly introduced DistinguishedNameParser ends up hiding the ones in the libraries. Bug: 26647082 Change-Id: I735aef3c1e5dd04e5a8e2eda6da6d9c9179f1c70 --- core/java/org/apache/http/conn/ssl/AbstractVerifier.java | 4 ++-- ...hedNameParser.java => AndroidDistinguishedNameParser.java} | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) rename core/java/org/apache/http/conn/ssl/{DistinguishedNameParser.java => AndroidDistinguishedNameParser.java} (99%) diff --git a/core/java/org/apache/http/conn/ssl/AbstractVerifier.java b/core/java/org/apache/http/conn/ssl/AbstractVerifier.java index 66a5121c4a311..b9349b39ba94b 100644 --- a/core/java/org/apache/http/conn/ssl/AbstractVerifier.java +++ b/core/java/org/apache/http/conn/ssl/AbstractVerifier.java @@ -208,8 +208,8 @@ public abstract class AbstractVerifier implements X509HostnameVerifier { } public static String[] getCNs(X509Certificate cert) { - DistinguishedNameParser dnParser = - new DistinguishedNameParser(cert.getSubjectX500Principal()); + AndroidDistinguishedNameParser dnParser = + new AndroidDistinguishedNameParser(cert.getSubjectX500Principal()); List cnList = dnParser.getAllMostSpecificFirst("cn"); if(!cnList.isEmpty()) { diff --git a/core/java/org/apache/http/conn/ssl/DistinguishedNameParser.java b/core/java/org/apache/http/conn/ssl/AndroidDistinguishedNameParser.java similarity index 99% rename from core/java/org/apache/http/conn/ssl/DistinguishedNameParser.java rename to core/java/org/apache/http/conn/ssl/AndroidDistinguishedNameParser.java index b2d0e3edbaf72..4f0b72693a622 100644 --- a/core/java/org/apache/http/conn/ssl/DistinguishedNameParser.java +++ b/core/java/org/apache/http/conn/ssl/AndroidDistinguishedNameParser.java @@ -29,7 +29,7 @@ import javax.security.auth.x500.X500Principal; * @hide */ @Deprecated -final class DistinguishedNameParser { +final class AndroidDistinguishedNameParser { private final String dn; private final int length; private int pos; @@ -42,7 +42,7 @@ final class DistinguishedNameParser { /** distinguished name chars */ private char[] chars; - public DistinguishedNameParser(X500Principal principal) { + public AndroidDistinguishedNameParser(X500Principal principal) { // RFC2253 is used to ensure we get attributes in the reverse // order of the underlying ASN.1 encoding, so that the most // significant values of repeated attributes occur first.