From 3113db6798d79a9b3b22ad6a6cc0c919cb081dc1 Mon Sep 17 00:00:00 2001 From: Lucas Dupin Date: Fri, 8 Mar 2019 18:21:27 -0800 Subject: [PATCH] Darker scrim when pulsing Bug: 111414690 Test: visual Change-Id: I562037425b3d722a5832fca8814b9794f7df33f7 --- .../android/systemui/statusbar/phone/ScrimController.java | 4 ++++ .../src/com/android/systemui/statusbar/phone/ScrimState.java | 5 ++--- .../systemui/statusbar/phone/ScrimControllerTest.java | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimController.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimController.java index 8714a51f98d41..c35b80fb8f739 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimController.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimController.java @@ -89,6 +89,10 @@ public class ScrimController implements ViewTreeObserver.OnPreDrawListener, OnCo * Default alpha value for most scrims. */ public static final float GRADIENT_SCRIM_ALPHA = 0.2f; + /** + * Scrim opacity when the phone is about to wake-up. + */ + public static final float AOD2_SCRIM_ALPHA = 0.6f; /** * A scrim varies its opacity based on a busyness factor, for example * how many notifications are currently visible. diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimState.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimState.java index ccf5e4eb0ac4a..2f161d5cd1925 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimState.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/ScrimState.java @@ -133,11 +133,10 @@ public enum ScrimState { || mPulseReason == DozeLog.PULSE_REASON_DOCKING || mPulseReason == DozeLog.PULSE_REASON_INTENT) { mCurrentBehindAlpha = previousState.getBehindAlpha(); - mCurrentBehindTint = Color.BLACK; } else { - mCurrentBehindAlpha = mScrimBehindAlphaKeyguard; - mCurrentBehindTint = Color.TRANSPARENT; + mCurrentBehindAlpha = ScrimController.AOD2_SCRIM_ALPHA; } + mCurrentBehindTint = Color.BLACK; mBlankScreen = mDisplayRequiresBlanking; } }, diff --git a/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java b/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java index 7e5c3db046e1c..539851f451538 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java @@ -232,7 +232,7 @@ public class ScrimControllerTest extends SysuiTestCase { // Back scrim should be semi-transparent so the user can see the wallpaper // Pulse callback should have been invoked assertScrimVisibility(VISIBILITY_FULLY_TRANSPARENT, VISIBILITY_SEMI_TRANSPARENT); - assertScrimTint(mScrimBehind, false /* tinted */); + assertScrimTint(mScrimBehind, true /* tinted */); } @Test