Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace fields with getters in keepalive API

Browse Source 
General guidance is to have getters in the API instead of fields.

Fixes: 181014882
Test: m
Change-Id: Id4bfc447701e8d0380163047779fbba043f17b6f
This commit is contained in:
Remi NGUYEN VAN
2021-04-08 13:59:10 +09:00
parent 5d7d6554c2
commit ab43b19bac
4 changed files with 91 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/net/common/java/android/net/TcpKeepalivePacketDataTest.kt
View File

@@ -92,12 +92,12 @@ class TcpKeepalivePacketDataTest {
assertTrue(str.contains(data.dstAddress.hostAddress))
assertTrue(str.contains(data.dstPort.toString()))
// .packet not included in toString()
assertTrue(str.contains(data.tcpSeq.toString()))
assertTrue(str.contains(data.tcpAck.toString()))
assertTrue(str.contains(data.tcpWindow.toString()))
assertTrue(str.contains(data.tcpWindowScale.toString()))
assertTrue(str.contains(data.ipTos.toString()))
assertTrue(str.contains(data.ipTtl.toString()))
assertTrue(str.contains(data.getTcpSeq().toString()))
assertTrue(str.contains(data.getTcpAck().toString()))
assertTrue(str.contains(data.getTcpWindow().toString()))
assertTrue(str.contains(data.getTcpWindowScale().toString()))
assertTrue(str.contains(data.getIpTos().toString()))
assertTrue(str.contains(data.getIpTtl().toString()))
// Update above assertions if field is added
assertFieldCountEquals(5, KeepalivePacketData::class.java)