From d3e90ea4ab74a5d2601c8553399deaedaf4db689 Mon Sep 17 00:00:00 2001 From: Mady Mellor Date: Tue, 9 May 2017 13:20:56 -0700 Subject: [PATCH] Slight adjustments to gradient shown when dragging to dismiss - Adjusted the height - Gave the asset a 90% alpha and set it as the background programmatically Test: manual, have a PIP drag it around, note the gradient appearance Change-Id: I7bc3262f6813f737da62201cdce6a14046f3e754 --- packages/SystemUI/res/layout/pip_dismiss_view.xml | 1 - packages/SystemUI/res/values/dimens.xml | 2 +- .../systemui/pip/phone/PipDismissViewController.java | 6 ++++++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/SystemUI/res/layout/pip_dismiss_view.xml b/packages/SystemUI/res/layout/pip_dismiss_view.xml index 058f59faa5663..2cc4b220fe2b7 100644 --- a/packages/SystemUI/res/layout/pip_dismiss_view.xml +++ b/packages/SystemUI/res/layout/pip_dismiss_view.xml @@ -17,7 +17,6 @@ 600dp - 196dp + 176dp 24dp diff --git a/packages/SystemUI/src/com/android/systemui/pip/phone/PipDismissViewController.java b/packages/SystemUI/src/com/android/systemui/pip/phone/PipDismissViewController.java index afb62fcec53b5..e1a7e3b3b65a7 100644 --- a/packages/SystemUI/src/com/android/systemui/pip/phone/PipDismissViewController.java +++ b/packages/SystemUI/src/com/android/systemui/pip/phone/PipDismissViewController.java @@ -21,6 +21,7 @@ import android.graphics.PixelFormat; import android.graphics.Point; import android.graphics.PointF; import android.graphics.Rect; +import android.graphics.drawable.Drawable; import android.view.Gravity; import android.view.LayoutInflater; import android.view.View; @@ -72,6 +73,11 @@ public class PipDismissViewController { mDismissView.setSystemUiVisibility(View.SYSTEM_UI_FLAG_LAYOUT_STABLE); mDismissView.forceHasOverlappingRendering(false); + // Set the gradient background + Drawable gradient = mContext.getResources().getDrawable(R.drawable.pip_dismiss_scrim); + gradient.setAlpha((int) (255 * 0.85f)); + mDismissView.setBackground(gradient); + // Adjust bottom margins of the text View text = mDismissView.findViewById(R.id.pip_dismiss_text); FrameLayout.LayoutParams tlp = (FrameLayout.LayoutParams) text.getLayoutParams();