From ab0a84d7a8d7b7a6be7381f54a0d6103ad87e288 Mon Sep 17 00:00:00 2001 From: Michal Brzezinski Date: Thu, 10 Feb 2022 18:13:39 +0000 Subject: [PATCH] Fixing not responsive tiles in split shade Some tiles (beyond QQS tiles) were not responsive because when QSPanelController is about to start listening, it also checks if mQsExpanded is set to true. mQsExpanded is passed from NotificationPanelViewController and it wasn't set to true because function setting it is never called in split shade. This change is hacky but probably safer way to solve it by changing condition for listening on changes. Bug: 218268829 Test: open split shade and tap night mode tile a few times - the tile must be positioned beyond first 6 tiles Merged-In: Id6ad9f199964dd416a52c169a3e30713389479cc Change-Id: Id6ad9f199964dd416a52c169a3e30713389479cc (cherry picked from commit d80184457b33efcf427a426efb31293f7428e009) --- .../src/com/android/systemui/qs/QSPanelController.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/qs/QSPanelController.java b/packages/SystemUI/src/com/android/systemui/qs/QSPanelController.java index 001c740e310a1..1837b5bf20440 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/QSPanelController.java +++ b/packages/SystemUI/src/com/android/systemui/qs/QSPanelController.java @@ -182,7 +182,9 @@ public class QSPanelController extends QSPanelControllerBase { /** */ public void setListening(boolean listening, boolean expanded) { - setListening(listening && expanded); + // TODO(218268829): checking for split shade is workaround but when proper fix lands + // "|| mShouldUseSplitNotificationShade" should be removed + setListening(listening && (expanded || mShouldUseSplitNotificationShade)); if (mView.isListening()) { refreshAllTiles(); }