From aa5c5e31de51d734543aa85f703bbc98b7759969 Mon Sep 17 00:00:00 2001 From: Henrik Baard Date: Tue, 3 Feb 2015 09:25:28 +0100 Subject: [PATCH] Remove fall through for KEYCODE_VOICE_ASSIST Removing unintentional fallthrough for the case KEYCODE_VOICE_ASSIST. The code works today since KEYCODE_VOICE_ASSIST is the last case in the switch statement, however it is bad practice. If somone adds another case statement the code will break. Change-Id: Iee6234807bbe176bd94e2584de288105d6c6a7cb --- .../src/com/android/internal/policy/impl/PhoneWindowManager.java | 1 + 1 file changed, 1 insertion(+) diff --git a/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java b/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java index b310e04f767ba..b46082027f01b 100644 --- a/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java +++ b/policy/src/com/android/internal/policy/impl/PhoneWindowManager.java @@ -4512,6 +4512,7 @@ public class PhoneWindowManager implements WindowManagerPolicy { msg.setAsynchronous(true); msg.sendToTarget(); } + break; } }