From 2ccb52785200bb2ac405b8b1a29c8632193546ce Mon Sep 17 00:00:00 2001 From: Manjeet Rulhania Date: Sun, 18 Dec 2022 01:12:16 +0000 Subject: [PATCH] fix typos Test: presubmit Change-Id: Ia8bdeebc38a69ffadac6c37fcdc0afab47c595e5 --- .../permission/PermissionManagerServiceImpl.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java b/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java index f9c0deb4c6487..d2d3c3c4eab1d 100644 --- a/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java +++ b/services/core/java/com/android/server/pm/permission/PermissionManagerServiceImpl.java @@ -683,7 +683,7 @@ public class PermissionManagerServiceImpl implements PermissionManagerServiceInt if (bp == null) { return; } - if (bp.isDynamic()) { + if (!bp.isDynamic()) { // TODO: switch this back to SecurityException Slog.wtf(TAG, "Not allowed to modify non-dynamic permission " + permName); @@ -1299,13 +1299,13 @@ public class PermissionManagerServiceImpl implements PermissionManagerServiceInt } } } + } - if ((flags & PackageManager.FLAG_PERMISSION_WHITELIST_INSTALLER) != 0) { - if (!isCallerPrivileged && !isCallerInstallerOnRecord) { - throw new SecurityException("Modifying installer allowlist requires" - + " being installer on record or " - + Manifest.permission.WHITELIST_RESTRICTED_PERMISSIONS); - } + if ((flags & PackageManager.FLAG_PERMISSION_WHITELIST_INSTALLER) != 0) { + if (!isCallerPrivileged && !isCallerInstallerOnRecord) { + throw new SecurityException("Modifying installer allowlist requires" + + " being installer on record or " + + Manifest.permission.WHITELIST_RESTRICTED_PERMISSIONS); } }