From a0ea350ae8c860787e8d76b3d7f55184dce1a0cd Mon Sep 17 00:00:00 2001 From: danielwbhuang Date: Thu, 16 Mar 2023 18:49:44 +0800 Subject: [PATCH] Remove Access emoji and Access voice typing shortcuts 1. These two shortcuts (Access emoji and Access voice typing) will be handed by Gboard, so it won't work if the current IME is not Gboard. So basically these two shortcuts should not be hardcoded in the UI. 2. Because Gboard can't receive shortcuts with meta modifier, we decided to change these two shortcuts to use alt modifier. And we may change these two shortcuts to other key combinations in future. So it's better to let Gboard (the current IME) provide their shortcuts and show them here. screenshot: https://screenshot.googleplex.com/9xG8sWafduQGuHA.png Bug: 259352579 Test: manual Change-Id: I132ddac876de5afd208e24adc410ae4d1f91a7f0 --- .../statusbar/KeyboardShortcutListSearch.java | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcutListSearch.java b/packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcutListSearch.java index 01e042bf5e159..c920e1ec6604b 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcutListSearch.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcutListSearch.java @@ -657,25 +657,6 @@ public final class KeyboardShortcutListSearch { R.string.input_switch_input_language_previous), KeyEvent.KEYCODE_SPACE, KeyEvent.META_META_ON | KeyEvent.META_SHIFT_ON), - null))), - /* Access emoji: Meta + . */ - new ShortcutMultiMappingInfo( - context.getString(R.string.input_access_emoji), - null, - Arrays.asList( - new ShortcutKeyGroup(new KeyboardShortcutInfo( - context.getString(R.string.input_access_emoji), - KeyEvent.KEYCODE_PERIOD, - KeyEvent.META_META_ON), - null))), - /* Access voice typing: Meta + V */ - new ShortcutMultiMappingInfo( - context.getString(R.string.input_access_voice_typing), - null, - Arrays.asList( - new ShortcutKeyGroup(new KeyboardShortcutInfo( - context.getString(R.string.input_access_voice_typing), - KeyEvent.KEYCODE_V, KeyEvent.META_META_ON), null))) ); return new KeyboardShortcutMultiMappingGroup(