From cb5f9db47a471620061ccb6a574afc209c610dd2 Mon Sep 17 00:00:00 2001 From: Fabrice Di Meglio Date: Fri, 30 Nov 2012 15:32:56 -0800 Subject: [PATCH] Fix bug #7651552 resetRtlProperties() is called way too often - remove unnecessary calls to resetRtlProperties(). - now reset of RTL properties will only be done when adding a View (and no more when removing it) Change-Id: I0d42128c9f7df6085fb92bb5af5c9bd4d1ba88a3 --- core/java/android/view/View.java | 2 -- core/java/android/view/ViewGroup.java | 17 ----------------- 2 files changed, 19 deletions(-) diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 17476276389d9..49da26dc9e2fc 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -11854,8 +11854,6 @@ public class View implements Drawable.Callback, KeyEvent.Callback, mCurrentAnimation = null; - resetRtlProperties(); - onRtlPropertiesChanged(LAYOUT_DIRECTION_DEFAULT); resetAccessibilityStateChanged(); } diff --git a/core/java/android/view/ViewGroup.java b/core/java/android/view/ViewGroup.java index 00723f3b91e35..dbbcde6d0f2b2 100644 --- a/core/java/android/view/ViewGroup.java +++ b/core/java/android/view/ViewGroup.java @@ -3620,8 +3620,6 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager childHasTransientStateChanged(view, false); } - view.resetRtlProperties(); - onViewRemoved(view); needGlobalAttributesUpdate(false); @@ -5368,21 +5366,6 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager } } - /** - * @hide - */ - @Override - public void resetRtlProperties() { - super.resetRtlProperties(); - int count = getChildCount(); - for (int i = 0; i < count; i++) { - final View child = getChildAt(i); - if (child.isLayoutDirectionInherited()) { - child.resetRtlProperties(); - } - } - } - /** * @hide */