From a8fd44b74b8822426cdc0e45351899c95bf30e16 Mon Sep 17 00:00:00 2001 From: Jinsuk Kim Date: Wed, 28 May 2014 17:42:56 +0900 Subject: [PATCH] DO NOT MERGE: Fix a couple of bugs in CEC services - Correct conversion for byte to int for cec opcode - Use the right Handler.obtainMessage() to pass an integer variable Change-Id: Ie3e86225f1702decce454aeb197911a371f51c17 --- core/java/android/hardware/hdmi/HdmiCecMessage.java | 2 +- services/core/java/com/android/server/hdmi/FeatureAction.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/core/java/android/hardware/hdmi/HdmiCecMessage.java b/core/java/android/hardware/hdmi/HdmiCecMessage.java index a8aa3763a6c12..62fa279b9c970 100644 --- a/core/java/android/hardware/hdmi/HdmiCecMessage.java +++ b/core/java/android/hardware/hdmi/HdmiCecMessage.java @@ -46,7 +46,7 @@ public final class HdmiCecMessage implements Parcelable { public HdmiCecMessage(int source, int destination, int opcode, byte[] params) { mSource = source; mDestination = destination; - mOpcode = opcode; + mOpcode = opcode & 0xFF; mParams = Arrays.copyOf(params, params.length); } diff --git a/services/core/java/com/android/server/hdmi/FeatureAction.java b/services/core/java/com/android/server/hdmi/FeatureAction.java index f8e9b7bca4e99..0ba7773d4b720 100644 --- a/services/core/java/com/android/server/hdmi/FeatureAction.java +++ b/services/core/java/com/android/server/hdmi/FeatureAction.java @@ -133,7 +133,8 @@ abstract class FeatureAction { @Override public void sendTimerMessage(int state, long delayMillis) { - sendMessageDelayed(obtainMessage(MSG_TIMEOUT, state), delayMillis); + // The third argument(0) is not used. + sendMessageDelayed(obtainMessage(MSG_TIMEOUT, state, 0), delayMillis); } @Override