Merge "Demote unstable assertions from presubmit" into sc-dev

This commit is contained in:
Nataniel Borges
2021-03-25 14:49:13 +00:00
committed by Android (Google) Code Review
6 changed files with 49 additions and 8 deletions

View File

@@ -136,7 +136,7 @@ class CloseImeAutoOpenWindowToHomeTest(private val testSpec: FlickerTestParamete
@Test @Test
fun statusBarLayerIsAlwaysVisible() = testSpec.statusBarLayerIsAlwaysVisible() fun statusBarLayerIsAlwaysVisible() = testSpec.statusBarLayerIsAlwaysVisible()
@Presubmit @FlakyTest
@Test @Test
fun visibleLayersShownMoreThanOneConsecutiveEntry() { fun visibleLayersShownMoreThanOneConsecutiveEntry() {
testSpec.assertLayers { testSpec.assertLayers {

View File

@@ -153,7 +153,7 @@ class ReOpenImeWindowTest(private val testSpec: FlickerTestParameter) {
testSpec.statusBarLayerRotatesScales(Surface.ROTATION_0, testSpec.config.endRotation) testSpec.statusBarLayerRotatesScales(Surface.ROTATION_0, testSpec.config.endRotation)
} }
@Presubmit @FlakyTest
@Test @Test
fun visibleLayersShownMoreThanOneConsecutiveEntry() { fun visibleLayersShownMoreThanOneConsecutiveEntry() {
testSpec.assertLayers { testSpec.assertLayers {

View File

@@ -16,6 +16,7 @@
package com.android.server.wm.flicker.launch package com.android.server.wm.flicker.launch
import androidx.test.filters.FlakyTest
import androidx.test.filters.RequiresDevice import androidx.test.filters.RequiresDevice
import com.android.server.wm.flicker.FlickerParametersRunnerFactory import com.android.server.wm.flicker.FlickerParametersRunnerFactory
import com.android.server.wm.flicker.FlickerTestParameter import com.android.server.wm.flicker.FlickerTestParameter
@@ -24,6 +25,7 @@ import com.android.server.wm.flicker.helpers.setRotation
import com.android.server.wm.flicker.startRotation import com.android.server.wm.flicker.startRotation
import com.android.server.wm.flicker.dsl.FlickerBuilder import com.android.server.wm.flicker.dsl.FlickerBuilder
import org.junit.FixMethodOrder import org.junit.FixMethodOrder
import org.junit.Test
import org.junit.runner.RunWith import org.junit.runner.RunWith
import org.junit.runners.MethodSorters import org.junit.runners.MethodSorters
import org.junit.runners.Parameterized import org.junit.runners.Parameterized
@@ -56,6 +58,12 @@ class OpenAppColdTest(testSpec: FlickerTestParameter) : OpenAppTransition(testSp
} }
} }
@FlakyTest
@Test
override fun visibleLayersShownMoreThanOneConsecutiveEntry() {
super.visibleLayersShownMoreThanOneConsecutiveEntry()
}
companion object { companion object {
@Parameterized.Parameters(name = "{0}") @Parameterized.Parameters(name = "{0}")
@JvmStatic @JvmStatic

View File

@@ -80,6 +80,24 @@ class OpenAppFromOverviewTest(testSpec: FlickerTestParameter) : OpenAppTransitio
super.navBarLayerRotatesAndScales() super.navBarLayerRotatesAndScales()
} }
@FlakyTest
@Test
override fun statusBarLayerRotatesScales() {
super.statusBarLayerRotatesScales()
}
@FlakyTest
@Test
override fun visibleLayersShownMoreThanOneConsecutiveEntry() {
super.visibleLayersShownMoreThanOneConsecutiveEntry()
}
@FlakyTest
@Test
override fun focusChanges() {
super.focusChanges()
}
companion object { companion object {
@Parameterized.Parameters(name = "{0}") @Parameterized.Parameters(name = "{0}")
@JvmStatic @JvmStatic

View File

@@ -16,6 +16,7 @@
package com.android.server.wm.flicker.launch package com.android.server.wm.flicker.launch
import androidx.test.filters.FlakyTest
import androidx.test.filters.RequiresDevice import androidx.test.filters.RequiresDevice
import com.android.server.wm.flicker.FlickerParametersRunnerFactory import com.android.server.wm.flicker.FlickerParametersRunnerFactory
import com.android.server.wm.flicker.FlickerTestParameter import com.android.server.wm.flicker.FlickerTestParameter
@@ -24,6 +25,7 @@ import com.android.server.wm.flicker.helpers.setRotation
import com.android.server.wm.flicker.startRotation import com.android.server.wm.flicker.startRotation
import com.android.server.wm.flicker.dsl.FlickerBuilder import com.android.server.wm.flicker.dsl.FlickerBuilder
import org.junit.FixMethodOrder import org.junit.FixMethodOrder
import org.junit.Test
import org.junit.runner.RunWith import org.junit.runner.RunWith
import org.junit.runners.MethodSorters import org.junit.runners.MethodSorters
import org.junit.runners.Parameterized import org.junit.runners.Parameterized
@@ -61,6 +63,18 @@ class OpenAppWarmTest(testSpec: FlickerTestParameter) : OpenAppTransition(testSp
} }
} }
@FlakyTest
@Test
override fun focusChanges() {
super.focusChanges()
}
@FlakyTest
@Test
override fun visibleLayersShownMoreThanOneConsecutiveEntry() {
super.visibleLayersShownMoreThanOneConsecutiveEntry()
}
companion object { companion object {
@Parameterized.Parameters(name = "{0}") @Parameterized.Parameters(name = "{0}")
@JvmStatic @JvmStatic

View File

@@ -18,6 +18,7 @@ package com.android.server.wm.flicker.rotation
import android.app.Instrumentation import android.app.Instrumentation
import android.platform.test.annotations.Presubmit import android.platform.test.annotations.Presubmit
import androidx.test.filters.FlakyTest
import androidx.test.platform.app.InstrumentationRegistry import androidx.test.platform.app.InstrumentationRegistry
import com.android.server.wm.flicker.FlickerBuilderProvider import com.android.server.wm.flicker.FlickerBuilderProvider
import com.android.server.wm.flicker.FlickerTestParameter import com.android.server.wm.flicker.FlickerTestParameter
@@ -79,7 +80,7 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
testSpec.navBarLayerIsAlwaysVisible() testSpec.navBarLayerIsAlwaysVisible()
} }
@Presubmit @FlakyTest
@Test @Test
open fun navBarLayerRotatesAndScales() { open fun navBarLayerRotatesAndScales() {
testSpec.navBarLayerRotatesAndScales( testSpec.navBarLayerRotatesAndScales(
@@ -98,14 +99,14 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
testSpec.statusBarLayerIsAlwaysVisible() testSpec.statusBarLayerIsAlwaysVisible()
} }
@Presubmit @FlakyTest
@Test @Test
open fun statusBarLayerRotatesScales() { open fun statusBarLayerRotatesScales() {
testSpec.statusBarLayerRotatesScales( testSpec.statusBarLayerRotatesScales(
testSpec.config.startRotation, testSpec.config.endRotation) testSpec.config.startRotation, testSpec.config.endRotation)
} }
@Presubmit @FlakyTest
@Test @Test
open fun visibleLayersShownMoreThanOneConsecutiveEntry() { open fun visibleLayersShownMoreThanOneConsecutiveEntry() {
testSpec.assertLayers { testSpec.assertLayers {
@@ -121,7 +122,7 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
} }
} }
@Presubmit @FlakyTest
@Test @Test
open fun noUncoveredRegions() { open fun noUncoveredRegions() {
testSpec.noUncoveredRegions(testSpec.config.startRotation, testSpec.noUncoveredRegions(testSpec.config.startRotation,
@@ -134,7 +135,7 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
testSpec.focusDoesNotChange() testSpec.focusDoesNotChange()
} }
@Presubmit @FlakyTest
@Test @Test
open fun appLayerRotates_StartingPos() { open fun appLayerRotates_StartingPos() {
testSpec.assertLayersStart { testSpec.assertLayersStart {
@@ -142,7 +143,7 @@ abstract class RotationTransition(protected val testSpec: FlickerTestParameter)
} }
} }
@Presubmit @FlakyTest
@Test @Test
open fun appLayerRotates_EndingPos() { open fun appLayerRotates_EndingPos() {
testSpec.assertLayersEnd { testSpec.assertLayersEnd {