From a9139bc7c514441d258dedd70bde1646ff60d9d9 Mon Sep 17 00:00:00 2001 From: Sehee Park Date: Fri, 22 Dec 2017 13:54:05 +0900 Subject: [PATCH] Add checking permission at the setDataSaverModeEnabled() Add calling enforceCallingOrSelfPermission() to check for NETWORK_SETTINGS permission at the setDataSaverModeEnabled(). When an application calls for setDataSaverModeEnabled() passing a true parameter, the access to Internet from mobile data became unavailable. Test: Run test app to call setDataSaverModeEnabled() with a true parameter. Test: Check the access to Internet from mobile data is available. Change-Id: I14af89923e61d81355052704081edf121ef7d06d Signed-off-by: Sehee Park --- .../core/java/com/android/server/NetworkManagementService.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/services/core/java/com/android/server/NetworkManagementService.java b/services/core/java/com/android/server/NetworkManagementService.java index 8a15ded2960f6..9224b925aca84 100644 --- a/services/core/java/com/android/server/NetworkManagementService.java +++ b/services/core/java/com/android/server/NetworkManagementService.java @@ -18,6 +18,7 @@ package com.android.server; import static android.Manifest.permission.CONNECTIVITY_INTERNAL; import static android.Manifest.permission.DUMP; +import static android.Manifest.permission.NETWORK_SETTINGS; import static android.Manifest.permission.NETWORK_STACK; import static android.Manifest.permission.SHUTDOWN; import static android.net.ConnectivityManager.PRIVATE_DNS_DEFAULT_MODE; @@ -1768,6 +1769,8 @@ public class NetworkManagementService extends INetworkManagementService.Stub @Override public boolean setDataSaverModeEnabled(boolean enable) { + mContext.enforceCallingOrSelfPermission(NETWORK_SETTINGS, TAG); + if (DBG) Log.d(TAG, "setDataSaverMode: " + enable); synchronized (mQuotaLock) { if (mDataSaverMode == enable) {