From f0b6921e894922b28143b281d006dee1285258f6 Mon Sep 17 00:00:00 2001
From: John Reck <jreck@google.com>
Date: Fri, 25 Jun 2021 17:33:33 +0000
Subject: [PATCH] Revert "Delete RenderProxy off of the cleaner thread"

This reverts commit da3559683482a61d93b06bed6f46349f6f01dc63.

Bug: b/192050906

If too many RenderProxies are destroyed too quickly, we can end up jamming up the CommonPool preventing RenderThread from making progress if it's waiting on CommonPool tasks.

Change-Id: I8c324bc60891440d9b7be67961f8d5f881dc0f03
---
 libs/hwui/jni/android_graphics_HardwareRenderer.cpp |  2 +-
 libs/hwui/renderthread/RenderProxy.cpp              | 12 ------------
 libs/hwui/renderthread/RenderProxy.h                |  8 ++------
 3 files changed, 3 insertions(+), 19 deletions(-)

diff --git a/libs/hwui/jni/android_graphics_HardwareRenderer.cpp b/libs/hwui/jni/android_graphics_HardwareRenderer.cpp
index 2c4402084160e..9ff2f461d40d7 100644
--- a/libs/hwui/jni/android_graphics_HardwareRenderer.cpp
+++ b/libs/hwui/jni/android_graphics_HardwareRenderer.cpp
@@ -247,7 +247,7 @@ static jlong android_view_ThreadedRenderer_createProxy(JNIEnv* env, jobject claz
 static void android_view_ThreadedRenderer_deleteProxy(JNIEnv* env, jobject clazz,
         jlong proxyPtr) {
     RenderProxy* proxy = reinterpret_cast<RenderProxy*>(proxyPtr);
-    RenderProxy::asyncDelete(proxy);
+    delete proxy;
 }
 
 static jboolean android_view_ThreadedRenderer_loadSystemProperties(JNIEnv* env, jobject clazz,
diff --git a/libs/hwui/renderthread/RenderProxy.cpp b/libs/hwui/renderthread/RenderProxy.cpp
index 8291fa7e4bab9..c47050c31e9aa 100644
--- a/libs/hwui/renderthread/RenderProxy.cpp
+++ b/libs/hwui/renderthread/RenderProxy.cpp
@@ -26,7 +26,6 @@
 #include "renderthread/CanvasContext.h"
 #include "renderthread/RenderTask.h"
 #include "renderthread/RenderThread.h"
-#include "thread/CommonPool.h"
 #include "utils/Macros.h"
 #include "utils/TimeUtils.h"
 
@@ -43,17 +42,6 @@ RenderProxy::RenderProxy(bool translucent, RenderNode* rootRenderNode,
     mDrawFrameTask.setContext(&mRenderThread, mContext, rootRenderNode);
 }
 
-void RenderProxy::asyncDelete(RenderProxy* proxy) {
-    if (!proxy) return;
-
-    if (proxy->mContext) {
-        // Use the common pool because ~RenderProxy blocks on calling into RenderThread
-        CommonPool::post([proxy]() { delete proxy; });
-    } else {
-        delete proxy;
-    }
-}
-
 RenderProxy::~RenderProxy() {
     destroyContext();
 }
diff --git a/libs/hwui/renderthread/RenderProxy.h b/libs/hwui/renderthread/RenderProxy.h
index f4bcd07b2ef4a..d575aa77e4ab4 100644
--- a/libs/hwui/renderthread/RenderProxy.h
+++ b/libs/hwui/renderthread/RenderProxy.h
@@ -62,14 +62,10 @@ enum {
  * references RenderProxy fields. This is safe as RenderProxy cannot
  * be deleted if it is blocked inside a call.
  */
-class RenderProxy final {
+class RenderProxy {
 public:
     RenderProxy(bool opaque, RenderNode* rootNode, IContextFactory* contextFactory);
-    ~RenderProxy();
-
-    // Schedules a delete of the RenderProxy at a later date. Avoids blocking the current thread
-    // on destruction which ~RenderProxy does by default.
-    static void asyncDelete(RenderProxy*);
+    virtual ~RenderProxy();
 
     // Won't take effect until next EGLSurface creation
     void setSwapBehavior(SwapBehavior swapBehavior);