Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Don't apply filter in readback, when there is no scaling" into pi-dev

Browse Source 
am: cea247e135

Change-Id: Ibfcc41e052376d159886410d11130bb89ade168d
This commit is contained in:
Stan Iliev
2018-06-25 16:33:36 -07:00
committed by android-build-merger
parent d3f3a2354a cea247e135
commit a69eae92c7
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libs/hwui/pipeline/skia/SkiaOpenGLReadback.cpp
View File

@@ -26,6 +26,7 @@
#include "DeviceInfo.h" #include "DeviceInfo.h"
#include "Matrix.h" #include "Matrix.h"
#include "Properties.h" #include "Properties.h"
#include "utils/MathUtils.h"
using namespace android::uirenderer::renderthread; using namespace android::uirenderer::renderthread;
@@ -116,9 +117,9 @@ CopyResult SkiaOpenGLReadback::copyImageInto(EGLImageKHR eglImage, const Matrix4
paint.setBlendMode(SkBlendMode::kSrc); paint.setBlendMode(SkBlendMode::kSrc);
// Apply a filter, which is matching OpenGL pipeline readback behaviour. Filter usage // Apply a filter, which is matching OpenGL pipeline readback behaviour. Filter usage
// is codified by tests using golden images like DecodeAccuracyTest. // is codified by tests using golden images like DecodeAccuracyTest.
if (skiaSrcRect.width() != bitmap->width() || bool disableFilter = MathUtils::areEqual(skiaSrcRect.width(), skiaDestRect.width())
skiaSrcRect.height() != bitmap->height()) { && MathUtils::areEqual(skiaSrcRect.height(), skiaDestRect.height());
// TODO: apply filter always, but check if tests will be fine if (!disableFilter) {
paint.setFilterQuality(kLow_SkFilterQuality); paint.setFilterQuality(kLow_SkFilterQuality);
} }
scaledSurface->getCanvas()->concat(textureMatrix); scaledSurface->getCanvas()->concat(textureMatrix);