Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "MTP: fix a memory leak" into sc-dev

Browse Source
This commit is contained in:
George Burgess
2021-07-22 17:26:32 +00:00
committed by Android (Google) Code Review
parent a9949c86c6 e485264ff5
commit a66b67936f
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
media/jni/android_mtp_MtpDevice.cpp
View File

@@ -416,20 +416,14 @@ android_mtp_MtpDevice_set_device_property_init_version(JNIEnv *env, jobject thiz
return -1; return -1;
} }
MtpProperty* property = new MtpProperty(MTP_DEVICE_PROPERTY_SESSION_INITIATOR_VERSION_INFO, MtpProperty property(MTP_DEVICE_PROPERTY_SESSION_INITIATOR_VERSION_INFO, MTP_TYPE_STR, true);
MTP_TYPE_STR, true); if (property.getDataType() != MTP_TYPE_STR) {
if (!property) {
env->ThrowNew(clazz_io_exception, "Failed to obtain property.");
return -1;
}
if (property->getDataType() != MTP_TYPE_STR) {
env->ThrowNew(clazz_io_exception, "Unexpected property data type."); env->ThrowNew(clazz_io_exception, "Unexpected property data type.");
return -1; return -1;
} }
property->setCurrentValue(propertyStr); property.setCurrentValue(propertyStr);
if (!device->setDevicePropValueStr(property)) { if (!device->setDevicePropValueStr(&property)) {
env->ThrowNew(clazz_io_exception, "Failed to obtain property value."); env->ThrowNew(clazz_io_exception, "Failed to obtain property value.");
return -1; return -1;
} }