From 2893302afc4137e63c9174a5d471d1f18b8b5d87 Mon Sep 17 00:00:00 2001 From: Sudheer Shanka Date: Mon, 14 Mar 2016 14:59:52 -0700 Subject: [PATCH] Call preference.setEnabled only after updating disabledByAdmin state. We check the value of disabledByAdmin state in setEnabled, so update it first before calling setEnabled. Bug: 27642236 Change-Id: Ie6c805b85a3afb87ffdaad0b80dbadc172b62d49 --- .../android/settingslib/RestrictedPreferenceHelper.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java b/packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java index 47023c108eab8..d0aba227baa5a 100644 --- a/packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java +++ b/packages/SettingsLib/src/com/android/settingslib/RestrictedPreferenceHelper.java @@ -146,12 +146,13 @@ public class RestrictedPreferenceHelper { public boolean setDisabledByAdmin(EnforcedAdmin admin) { final boolean disabled = (admin != null ? true : false); mEnforcedAdmin = admin; - mPreference.setEnabled(!disabled); + boolean changed = false; if (mDisabledByAdmin != disabled) { mDisabledByAdmin = disabled; - return true; + changed = true; } - return false; + mPreference.setEnabled(!disabled); + return changed; } public boolean isDisabledByAdmin() {