From 6611988429d1d70ec429f87bbf2b093cf1e2e31f Mon Sep 17 00:00:00 2001 From: Winson Chung Date: Thu, 11 Oct 2012 14:26:25 -0700 Subject: [PATCH] Letting partial update fall through if the widget has not received a full update yet. (Bug 7214731) Change-Id: I4da99c259df51f8f66d3ade1156040bd0360ca5d --- core/java/android/appwidget/AppWidgetManager.java | 8 ++++++++ .../java/com/android/server/AppWidgetServiceImpl.java | 7 +++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/core/java/android/appwidget/AppWidgetManager.java b/core/java/android/appwidget/AppWidgetManager.java index 888955cc4e2b9..2af65b90b84b8 100644 --- a/core/java/android/appwidget/AppWidgetManager.java +++ b/core/java/android/appwidget/AppWidgetManager.java @@ -448,6 +448,10 @@ public class AppWidgetManager { * and outside of the handler. * This method will only work when called from the uid that owns the AppWidget provider. * + *

+ * This method will be ignored if a widget has not received a full update via + * {@link #updateAppWidget(int[], RemoteViews)}. + * * @param appWidgetIds The AppWidget instances for which to set the RemoteViews. * @param views The RemoteViews object containing the incremental update / command. */ @@ -476,6 +480,10 @@ public class AppWidgetManager { * and outside of the handler. * This method will only work when called from the uid that owns the AppWidget provider. * + *

+ * This method will be ignored if a widget has not received a full update via + * {@link #updateAppWidget(int[], RemoteViews)}. + * * @param appWidgetId The AppWidget instance for which to set the RemoteViews. * @param views The RemoteViews object containing the incremental update / command. */ diff --git a/services/java/com/android/server/AppWidgetServiceImpl.java b/services/java/com/android/server/AppWidgetServiceImpl.java index 04cfa4f4edc42..9fea6f3054da1 100644 --- a/services/java/com/android/server/AppWidgetServiceImpl.java +++ b/services/java/com/android/server/AppWidgetServiceImpl.java @@ -943,7 +943,10 @@ class AppWidgetServiceImpl { ensureStateLoadedLocked(); for (int i = 0; i < N; i++) { AppWidgetId id = lookupAppWidgetIdLocked(appWidgetIds[i]); - updateAppWidgetInstanceLocked(id, views, true); + if (id.views != null) { + // Only trigger a partial update for a widget if it has received a full update + updateAppWidgetInstanceLocked(id, views, true); + } } } } @@ -996,7 +999,7 @@ class AppWidgetServiceImpl { // drop unbound appWidgetIds (shouldn't be possible under normal circumstances) if (id != null && id.provider != null && !id.provider.zombie && !id.host.zombie) { - if (!isPartialUpdate || id.views == null) { + if (!isPartialUpdate) { // For a full update we replace the RemoteViews completely. id.views = views; } else {