From dc5a63bdd153f32d68962bc8271079295b41e1ee Mon Sep 17 00:00:00 2001 From: Jack Yu Date: Fri, 29 Jul 2016 15:01:18 -0700 Subject: [PATCH] Added todo items for a potential metrics issue bug: 29390529 Change-Id: I15826d5f513748a423eb4cc103f1b010ddad2126 --- core/java/android/net/ConnectivityMetricsLogger.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/core/java/android/net/ConnectivityMetricsLogger.java b/core/java/android/net/ConnectivityMetricsLogger.java index 029c5bdccd41b..415f46902169d 100644 --- a/core/java/android/net/ConnectivityMetricsLogger.java +++ b/core/java/android/net/ConnectivityMetricsLogger.java @@ -96,6 +96,12 @@ public class ConnectivityMetricsLogger { // Log number of skipped events Bundle b = new Bundle(); b.putInt(DATA_KEY_EVENTS_COUNT, mNumSkippedEvents); + + // Log the skipped event. + // TODO: Note that some of the clients push all states events into the server, + // If we lose some states logged here, we might mess up the statistics happened at the + // backend. One of the options is to introduce a non-skippable flag for important events + // that are logged. skippedEventsEvent = new ConnectivityMetricsEvent(mServiceUnblockedTimestampMillis, componentTag, TAG_SKIPPED_EVENTS, b);