From a4ddfbe33b764e554d5a310509efd5af6cd0226d Mon Sep 17 00:00:00 2001 From: Liz Kammer Date: Thu, 22 Jul 2021 10:09:32 -0400 Subject: [PATCH] Mark classes as final that have final destructors Having a final destructor prevents the class from being inherited from, adding the designation final to the class makes this behavior more explicit. This is required to re-enable the error for -Wno-final-dtor-non-final-class. Test: m Merged-In: Ia3126d30e19edfd17f7c8da368e9763ca5501e84 Change-Id: Id1d7c607af9cca0109e1f763052894cf179f4af1 --- services/incremental/ServiceWrappers.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/incremental/ServiceWrappers.cpp b/services/incremental/ServiceWrappers.cpp index 99a35adb50744..2b5f98b64760e 100644 --- a/services/incremental/ServiceWrappers.cpp +++ b/services/incremental/ServiceWrappers.cpp @@ -132,7 +132,7 @@ private: } mLooper; }; -class RealIncFs : public IncFsWrapper { +class RealIncFs final : public IncFsWrapper { public: RealIncFs() = default; ~RealIncFs() final = default; @@ -185,7 +185,7 @@ public: static JNIEnv* getOrAttachJniEnv(JavaVM* jvm); -class RealTimedQueueWrapper : public TimedQueueWrapper { +class RealTimedQueueWrapper final : public TimedQueueWrapper { public: RealTimedQueueWrapper(JavaVM* jvm) { mThread = std::thread([this, jvm]() {