From a49ba3ac12df5affc26c25ac8740f74ca44850b7 Mon Sep 17 00:00:00 2001 From: Jeff Sharkey Date: Fri, 16 Oct 2020 20:38:38 -0600 Subject: [PATCH] Trivial refactor for consistent naming. This gives all our various new performance-related checkers a consistent "EfficientFooChecker" naming style. Bug: 155703208 Test: atest error_prone_android_framework_test Change-Id: I8809fe46d20357201c8559037b468d717319afb9 --- ...erformanceChecker.java => EfficientParcelableChecker.java} | 4 ++-- ...ceCheckerTest.java => EfficientParcelableCheckerTest.java} | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) rename errorprone/java/com/google/errorprone/bugpatterns/android/{ParcelablePerformanceChecker.java => EfficientParcelableChecker.java} (98%) rename errorprone/tests/java/com/google/errorprone/bugpatterns/android/{ParcelablePerformanceCheckerTest.java => EfficientParcelableCheckerTest.java} (97%) diff --git a/errorprone/java/com/google/errorprone/bugpatterns/android/ParcelablePerformanceChecker.java b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientParcelableChecker.java similarity index 98% rename from errorprone/java/com/google/errorprone/bugpatterns/android/ParcelablePerformanceChecker.java rename to errorprone/java/com/google/errorprone/bugpatterns/android/EfficientParcelableChecker.java index d5243164abdc1..c29a095ecc1be 100644 --- a/errorprone/java/com/google/errorprone/bugpatterns/android/ParcelablePerformanceChecker.java +++ b/errorprone/java/com/google/errorprone/bugpatterns/android/EfficientParcelableChecker.java @@ -43,10 +43,10 @@ import com.sun.source.tree.Tree; */ @AutoService(BugChecker.class) @BugPattern( - name = "AndroidFrameworkParcelablePerformance", + name = "AndroidFrameworkEfficientParcelable", summary = "Verifies Parcelable performance best-practices", severity = WARNING) -public final class ParcelablePerformanceChecker extends BugChecker +public final class EfficientParcelableChecker extends BugChecker implements MethodInvocationTreeMatcher { private static final Matcher INSIDE_WRITE_TO_PARCEL = allOf( enclosingClass(isSubtypeOf("android.os.Parcelable")), diff --git a/errorprone/tests/java/com/google/errorprone/bugpatterns/android/ParcelablePerformanceCheckerTest.java b/errorprone/tests/java/com/google/errorprone/bugpatterns/android/EfficientParcelableCheckerTest.java similarity index 97% rename from errorprone/tests/java/com/google/errorprone/bugpatterns/android/ParcelablePerformanceCheckerTest.java rename to errorprone/tests/java/com/google/errorprone/bugpatterns/android/EfficientParcelableCheckerTest.java index 75c76e32f00e5..a40414bc1cefa 100644 --- a/errorprone/tests/java/com/google/errorprone/bugpatterns/android/ParcelablePerformanceCheckerTest.java +++ b/errorprone/tests/java/com/google/errorprone/bugpatterns/android/EfficientParcelableCheckerTest.java @@ -24,13 +24,13 @@ import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @RunWith(JUnit4.class) -public class ParcelablePerformanceCheckerTest { +public class EfficientParcelableCheckerTest { private CompilationTestHelper compilationHelper; @Before public void setUp() { compilationHelper = CompilationTestHelper.newInstance( - ParcelablePerformanceChecker.class, getClass()); + EfficientParcelableChecker.class, getClass()); } @Test