Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[DO NOT MERGE] Update BP "Not recognized" message with UX/UI spec

Browse Source 
Change the string on the biometric prompt when fingerprint/face failed
according to biometric enrollment status

Fixes: 286993443
Fixes: 286967857
Test: Manual (see bug)
Test: atest AuthControllerTest atest BiometricsServiceTest
Change-Id: Ieaecf678d9498b065972340900ddb5afba97ac1e
Merged-In: Ieaecf678d9498b065972340900ddb5afba97ac1e
This commit is contained in:
Wenhui Yang
2023-06-15 22:53:32 +00:00
parent 6ac49b8a2c
commit a39a975e7b
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/SystemUI/src/com/android/systemui/biometrics/AuthController.java
View File

@@ -1049,8 +1049,16 @@ public class AuthController implements CoreStartable, CommandQueue.Callbacks,
}
private String getNotRecognizedString(@Modality int modality) {
return mContext.getString(modality == TYPE_FACE
? R.string.biometric_face_not_recognized : R.string.biometric_not_recognized);
final int messageRes;
final int userId = mCurrentDialogArgs.argi1;
if (isFaceAuthEnrolled(userId) && isFingerprintEnrolled(userId)) {
messageRes = modality == TYPE_FACE
? R.string.biometric_face_not_recognized
: R.string.fingerprint_error_not_match;
} else {
messageRes = R.string.biometric_not_recognized;
}
return mContext.getString(messageRes);
}
private String getErrorString(@Modality int modality, int error, int vendorCode) {

4
services/tests/servicestests/src/com/android/server/biometrics/BiometricServiceTest.java
View File

@@ -182,6 +182,10 @@ public class BiometricServiceTest {
.thenReturn(ERROR_HW_UNAVAILABLE);
when(mResources.getString(R.string.biometric_not_recognized))
.thenReturn(ERROR_NOT_RECOGNIZED);
when(mResources.getString(R.string.biometric_face_not_recognized))
.thenReturn(ERROR_NOT_RECOGNIZED);
when(mResources.getString(R.string.fingerprint_error_not_match))
.thenReturn(ERROR_NOT_RECOGNIZED);
when(mResources.getString(R.string.biometric_error_user_canceled))
.thenReturn(ERROR_USER_CANCELED);