From c5f5941f0c742968c478061079e735985ab41783 Mon Sep 17 00:00:00 2001 From: Will Burr Date: Fri, 19 Aug 2022 12:35:30 +0000 Subject: [PATCH] ActivityManagerService: add SdkSandbox-Client-Package header Add SdkSandbox-Client-Package header to dropbox reports generated for a SDK sandbox crash. Bug: 239806676 Test: manual (adb shell dumpsys dropbox) Change-Id: Id32fbe91493ef8adcda01d534668d27e7619f943 --- .../server/am/ActivityManagerService.java | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/services/core/java/com/android/server/am/ActivityManagerService.java b/services/core/java/com/android/server/am/ActivityManagerService.java index 147b5507346c4..ef9b2ed616fe5 100644 --- a/services/core/java/com/android/server/am/ActivityManagerService.java +++ b/services/core/java/com/android/server/am/ActivityManagerService.java @@ -8745,12 +8745,40 @@ public class ActivityManagerService extends IActivityManager.Stub if (process.info.isInstantApp()) { sb.append("Instant-App: true\n"); } + if (isSdkSandboxUid(process.uid)) { + final int appUid = Process.getAppUidForSdkSandboxUid(process.uid); + try { + String[] clientPackages = pm.getPackagesForUid(appUid); + // In shared UID case, don't add the package information + if (clientPackages.length == 1) { + appendSdkSandboxClientPackageHeader(sb, clientPackages[0], callingUserId); + } + } catch (RemoteException e) { + Slog.e(TAG, "Error getting packages for client app uid: " + appUid, e); + } sb.append("SdkSandbox: true\n"); } } } + private void appendSdkSandboxClientPackageHeader(StringBuilder sb, String pkg, int userId) { + final IPackageManager pm = AppGlobals.getPackageManager(); + sb.append("SdkSandbox-Client-Package: ").append(pkg); + try { + final PackageInfo pi = pm.getPackageInfo(pkg, 0, userId); + if (pi != null) { + sb.append(" v").append(pi.getLongVersionCode()); + if (pi.versionName != null) { + sb.append(" (").append(pi.versionName).append(")"); + } + } + } catch (RemoteException e) { + Slog.e(TAG, "Error getting package info for SDK sandbox client: " + pkg, e); + } + sb.append("\n"); + } + private static String processClass(ProcessRecord process) { if (process == null || process.getPid() == MY_PID) { return "system_server";