Merge "Add reminder in the code to fix T-junctions"

This commit is contained in:
Romain Guy
2011-09-07 17:57:00 -07:00
committed by Android (Google) Code Review
2 changed files with 9 additions and 0 deletions

View File

@@ -91,6 +91,13 @@ Region* LayerRenderer::getRegion() {
#endif
}
// TODO: This implementation is flawed and can generate T-junctions
// in the mesh, which will in turn produce cracks when the
// mesh is rotated/skewed. The easiest way to fix this would
// be, for each row, to add new vertices shared with the previous
// row when the two rows share an edge.
// In practice, T-junctions do not appear often so this has yet
// to be fixed.
void LayerRenderer::generateMesh() {
#if RENDER_LAYERS_AS_REGIONS
if (mLayer->region.isRect() || mLayer->region.isEmpty()) {

View File

@@ -724,6 +724,8 @@ void OpenGLRenderer::composeLayerRegion(Layer* layer, const Rect& rect) {
return;
}
// TODO: See LayerRenderer.cpp::generateMesh() for important
// information about this implementation
if (!layer->region.isEmpty()) {
size_t count;
const android::Rect* rects = layer->region.getArray(&count);