Merge "Remove unused OverlayManager injected instance and InteractionJankMonitor from One-handed mode" into tm-qpr-dev

This commit is contained in:
Winson Chung
2022-07-16 02:08:42 +00:00
committed by Android (Google) Code Review
3 changed files with 1 additions and 31 deletions

View File

@@ -28,12 +28,10 @@ import static com.android.wm.shell.onehanded.OneHandedState.STATE_NONE;
import android.annotation.BinderThread; import android.annotation.BinderThread;
import android.content.ComponentName; import android.content.ComponentName;
import android.content.Context; import android.content.Context;
import android.content.om.IOverlayManager;
import android.content.res.Configuration; import android.content.res.Configuration;
import android.database.ContentObserver; import android.database.ContentObserver;
import android.graphics.Rect; import android.graphics.Rect;
import android.os.Handler; import android.os.Handler;
import android.os.ServiceManager;
import android.os.SystemProperties; import android.os.SystemProperties;
import android.provider.Settings; import android.provider.Settings;
import android.util.Slog; import android.util.Slog;
@@ -92,7 +90,6 @@ public class OneHandedController implements RemoteCallable<OneHandedController>,
private final OneHandedState mState; private final OneHandedState mState;
private final OneHandedTutorialHandler mTutorialHandler; private final OneHandedTutorialHandler mTutorialHandler;
private final TaskStackListenerImpl mTaskStackListener; private final TaskStackListenerImpl mTaskStackListener;
private final IOverlayManager mOverlayManager;
private final ShellExecutor mMainExecutor; private final ShellExecutor mMainExecutor;
private final Handler mMainHandler; private final Handler mMainHandler;
private final OneHandedImpl mImpl = new OneHandedImpl(); private final OneHandedImpl mImpl = new OneHandedImpl();
@@ -210,11 +207,9 @@ public class OneHandedController implements RemoteCallable<OneHandedController>,
context, displayLayout, settingsUtil, animationController, tutorialHandler, context, displayLayout, settingsUtil, animationController, tutorialHandler,
jankMonitor, mainExecutor); jankMonitor, mainExecutor);
OneHandedUiEventLogger oneHandedUiEventsLogger = new OneHandedUiEventLogger(uiEventLogger); OneHandedUiEventLogger oneHandedUiEventsLogger = new OneHandedUiEventLogger(uiEventLogger);
IOverlayManager overlayManager = IOverlayManager.Stub.asInterface(
ServiceManager.getService(Context.OVERLAY_SERVICE));
return new OneHandedController(context, displayController, organizer, touchHandler, return new OneHandedController(context, displayController, organizer, touchHandler,
tutorialHandler, settingsUtil, accessibilityUtil, timeoutHandler, oneHandedState, tutorialHandler, settingsUtil, accessibilityUtil, timeoutHandler, oneHandedState,
jankMonitor, oneHandedUiEventsLogger, overlayManager, taskStackListener, oneHandedUiEventsLogger, taskStackListener,
mainExecutor, mainHandler); mainExecutor, mainHandler);
} }
@@ -228,9 +223,7 @@ public class OneHandedController implements RemoteCallable<OneHandedController>,
OneHandedAccessibilityUtil oneHandedAccessibilityUtil, OneHandedAccessibilityUtil oneHandedAccessibilityUtil,
OneHandedTimeoutHandler timeoutHandler, OneHandedTimeoutHandler timeoutHandler,
OneHandedState state, OneHandedState state,
InteractionJankMonitor jankMonitor,
OneHandedUiEventLogger uiEventsLogger, OneHandedUiEventLogger uiEventsLogger,
IOverlayManager overlayManager,
TaskStackListenerImpl taskStackListener, TaskStackListenerImpl taskStackListener,
ShellExecutor mainExecutor, ShellExecutor mainExecutor,
Handler mainHandler) { Handler mainHandler) {
@@ -242,7 +235,6 @@ public class OneHandedController implements RemoteCallable<OneHandedController>,
mTouchHandler = touchHandler; mTouchHandler = touchHandler;
mState = state; mState = state;
mTutorialHandler = tutorialHandler; mTutorialHandler = tutorialHandler;
mOverlayManager = overlayManager;
mMainExecutor = mainExecutor; mMainExecutor = mainExecutor;
mMainHandler = mainHandler; mMainHandler = mainHandler;
mOneHandedUiEventLogger = uiEventsLogger; mOneHandedUiEventLogger = uiEventsLogger;

View File

@@ -33,7 +33,6 @@ import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import android.content.om.IOverlayManager;
import android.graphics.Rect; import android.graphics.Rect;
import android.os.Handler; import android.os.Handler;
import android.os.UserHandle; import android.os.UserHandle;
@@ -41,12 +40,10 @@ import android.testing.AndroidTestingRunner;
import android.util.ArrayMap; import android.util.ArrayMap;
import android.view.Display; import android.view.Display;
import android.view.Surface; import android.view.Surface;
import android.view.SurfaceControl;
import android.window.WindowContainerTransaction; import android.window.WindowContainerTransaction;
import androidx.test.filters.SmallTest; import androidx.test.filters.SmallTest;
import com.android.internal.jank.InteractionJankMonitor;
import com.android.wm.shell.common.DisplayController; import com.android.wm.shell.common.DisplayController;
import com.android.wm.shell.common.DisplayLayout; import com.android.wm.shell.common.DisplayLayout;
import com.android.wm.shell.common.ShellExecutor; import com.android.wm.shell.common.ShellExecutor;
@@ -87,16 +84,10 @@ public class OneHandedControllerTest extends OneHandedTestCase {
@Mock @Mock
OneHandedUiEventLogger mMockUiEventLogger; OneHandedUiEventLogger mMockUiEventLogger;
@Mock @Mock
InteractionJankMonitor mMockJankMonitor;
@Mock
IOverlayManager mMockOverlayManager;
@Mock
TaskStackListenerImpl mMockTaskStackListener; TaskStackListenerImpl mMockTaskStackListener;
@Mock @Mock
ShellExecutor mMockShellMainExecutor; ShellExecutor mMockShellMainExecutor;
@Mock @Mock
SurfaceControl mMockLeash;
@Mock
Handler mMockShellMainHandler; Handler mMockShellMainHandler;
final boolean mDefaultEnabled = true; final boolean mDefaultEnabled = true;
@@ -140,9 +131,7 @@ public class OneHandedControllerTest extends OneHandedTestCase {
mOneHandedAccessibilityUtil, mOneHandedAccessibilityUtil,
mSpiedTimeoutHandler, mSpiedTimeoutHandler,
mSpiedTransitionState, mSpiedTransitionState,
mMockJankMonitor,
mMockUiEventLogger, mMockUiEventLogger,
mMockOverlayManager,
mMockTaskStackListener, mMockTaskStackListener,
mMockShellMainExecutor, mMockShellMainExecutor,
mMockShellMainHandler) mMockShellMainHandler)

View File

@@ -29,18 +29,15 @@ import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify; import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import android.content.om.IOverlayManager;
import android.graphics.Rect; import android.graphics.Rect;
import android.os.Handler; import android.os.Handler;
import android.os.UserHandle; import android.os.UserHandle;
import android.testing.AndroidTestingRunner; import android.testing.AndroidTestingRunner;
import android.util.ArrayMap; import android.util.ArrayMap;
import android.view.Display; import android.view.Display;
import android.view.SurfaceControl;
import androidx.test.filters.SmallTest; import androidx.test.filters.SmallTest;
import com.android.internal.jank.InteractionJankMonitor;
import com.android.wm.shell.common.DisplayController; import com.android.wm.shell.common.DisplayController;
import com.android.wm.shell.common.DisplayLayout; import com.android.wm.shell.common.DisplayLayout;
import com.android.wm.shell.common.ShellExecutor; import com.android.wm.shell.common.ShellExecutor;
@@ -77,16 +74,10 @@ public class OneHandedStateTest extends OneHandedTestCase {
@Mock @Mock
OneHandedUiEventLogger mMockUiEventLogger; OneHandedUiEventLogger mMockUiEventLogger;
@Mock @Mock
InteractionJankMonitor mMockJankMonitor;
@Mock
IOverlayManager mMockOverlayManager;
@Mock
TaskStackListenerImpl mMockTaskStackListener; TaskStackListenerImpl mMockTaskStackListener;
@Mock @Mock
ShellExecutor mMockShellMainExecutor; ShellExecutor mMockShellMainExecutor;
@Mock @Mock
SurfaceControl mMockLeash;
@Mock
Handler mMockShellMainHandler; Handler mMockShellMainHandler;
final boolean mDefaultEnabled = true; final boolean mDefaultEnabled = true;
@@ -127,9 +118,7 @@ public class OneHandedStateTest extends OneHandedTestCase {
mOneHandedAccessibilityUtil, mOneHandedAccessibilityUtil,
mSpiedTimeoutHandler, mSpiedTimeoutHandler,
mSpiedState, mSpiedState,
mMockJankMonitor,
mMockUiEventLogger, mMockUiEventLogger,
mMockOverlayManager,
mMockTaskStackListener, mMockTaskStackListener,
mMockShellMainExecutor, mMockShellMainExecutor,
mMockShellMainHandler) mMockShellMainHandler)