From aa3c81e49791429a92282c752c89575cf5c01cb6 Mon Sep 17 00:00:00 2001 From: Geremy Condra Date: Thu, 4 Apr 2013 17:48:09 -0700 Subject: [PATCH] Fix crash in ConfigUpdater when the target dir doesn't exist. Change-Id: I44ee0e3791938da0bf890fb38cd886330c0ee01d --- .../android/server/updates/ConfigUpdateInstallReceiver.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/java/com/android/server/updates/ConfigUpdateInstallReceiver.java b/services/java/com/android/server/updates/ConfigUpdateInstallReceiver.java index d603cfaeee175..c94f7c1536037 100644 --- a/services/java/com/android/server/updates/ConfigUpdateInstallReceiver.java +++ b/services/java/com/android/server/updates/ConfigUpdateInstallReceiver.java @@ -226,8 +226,6 @@ public class ConfigUpdateInstallReceiver extends BroadcastReceiver { FileOutputStream out = null; File tmp = null; try { - // create the temporary file - tmp = File.createTempFile("journal", "", dir); // create the parents for the destination file File parent = file.getParentFile(); parent.mkdirs(); @@ -235,6 +233,8 @@ public class ConfigUpdateInstallReceiver extends BroadcastReceiver { if (!parent.exists()) { throw new IOException("Failed to create directory " + parent.getCanonicalPath()); } + // create the temporary file + tmp = File.createTempFile("journal", "", dir); // mark tmp -rw-r--r-- tmp.setReadable(true, false); // write to it