Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Prevent apps from spamming addAccountExplicitly. See comment here for the discussion on solution https://b.corp.google.com/issues/169762606#comment14" into pi-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2021-09-01 00:11:36 +00:00
committed by Android (Google) Code Review
parent b0fccf4d9d 5beff34b57
commit a0226b4d47
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/java/android/accounts/Account.java
View File

@@ -28,6 +28,7 @@ import android.util.ArraySet;
import android.util.Log; import android.util.Log;
import com.android.internal.annotations.GuardedBy; import com.android.internal.annotations.GuardedBy;
import java.util.Objects;
import java.util.Set; import java.util.Set;
/** /**
@@ -80,6 +81,12 @@ public class Account implements Parcelable {
if (TextUtils.isEmpty(type)) { if (TextUtils.isEmpty(type)) {
throw new IllegalArgumentException("the type must not be empty: " + type); throw new IllegalArgumentException("the type must not be empty: " + type);
} }
if (name.length() > 200) {
throw new IllegalArgumentException("account name is longer than 200 characters");
}
if (type.length() > 200) {
throw new IllegalArgumentException("account type is longer than 200 characters");
}
this.name = name; this.name = name;
this.type = type; this.type = type;
this.accessId = accessId; this.accessId = accessId;

5
services/core/java/com/android/server/accounts/AccountManagerService.java
View File

@@ -1790,6 +1790,11 @@ public class AccountManagerService
+ ", skipping since the account already exists"); + ", skipping since the account already exists");
return false; return false;
} }
if (accounts.accountsDb.findAllDeAccounts().size() > 100) {
Log.w(TAG, "insertAccountIntoDatabase: " + account
+ ", skipping since more than 50 accounts on device exist");
return false;
}
long accountId = accounts.accountsDb.insertCeAccount(account, password); long accountId = accounts.accountsDb.insertCeAccount(account, password);
if (accountId < 0) { if (accountId < 0) {
Log.w(TAG, "insertAccountIntoDatabase: " + account Log.w(TAG, "insertAccountIntoDatabase: " + account