Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Kill the app once a compat change override is changed."

Browse Source
This commit is contained in:
Anna Trostanetski
2019-10-03 09:23:31 +00:00
committed by Gerrit Code Review
parent 65e6a23e40 8851c3ccd3
commit 9ff2a6a098
1 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
services/core/java/com/android/server/am/ActivityManagerShellCommand.java
View File

@@ -2868,7 +2868,21 @@ final class ActivityManagerShellCommand extends ShellCommand {
return 0; return 0;
} }
private int runCompat(PrintWriter pw) { private void killPackage(String packageName, PrintWriter pw) throws RemoteException {
int uid = mPm.getPackageUid(packageName, 0, mUserId);
if (uid < 0) {
// uid is negative if the package wasn't found.
pw.println("Didn't find package " + packageName + " on device.");
} else {
pw.println("Killing package " + packageName + " (UID " + uid + ").");
final long origId = Binder.clearCallingIdentity();
mInterface.killUid(UserHandle.getAppId(uid),
UserHandle.USER_ALL, "killPackage");
Binder.restoreCallingIdentity(origId);
}
}
private int runCompat(PrintWriter pw) throws RemoteException {
final CompatConfig config = CompatConfig.get(); final CompatConfig config = CompatConfig.get();
String toggleValue = getNextArgRequired(); String toggleValue = getNextArgRequired();
long changeId; long changeId;
@@ -2889,6 +2903,7 @@ final class ActivityManagerShellCommand extends ShellCommand {
+ " could have no effect."); + " could have no effect.");
} }
pw.println("Enabled change " + changeId + " for " + packageName + "."); pw.println("Enabled change " + changeId + " for " + packageName + ".");
killPackage(packageName, pw);
return 0; return 0;
case "disable": case "disable":
if (!config.addOverride(changeId, packageName, false)) { if (!config.addOverride(changeId, packageName, false)) {
@@ -2896,11 +2911,13 @@ final class ActivityManagerShellCommand extends ShellCommand {
+ " could have no effect."); + " could have no effect.");
} }
pw.println("Disabled change " + changeId + " for " + packageName + "."); pw.println("Disabled change " + changeId + " for " + packageName + ".");
killPackage(packageName, pw);
return 0; return 0;
case "reset": case "reset":
if (config.removeOverride(changeId, packageName)) { if (config.removeOverride(changeId, packageName)) {
pw.println("Reset change " + changeId + " for " + packageName pw.println("Reset change " + changeId + " for " + packageName
+ " to default value."); + " to default value.");
killPackage(packageName, pw);
} else { } else {
pw.println("No override exists for changeId " + changeId + "."); pw.println("No override exists for changeId " + changeId + ".");
} }
@@ -3219,6 +3236,7 @@ final class ActivityManagerShellCommand extends ShellCommand {
pw.println(" Write all pending state to storage."); pw.println(" Write all pending state to storage.");
pw.println(" compat enable|disable|reset <CHANGE_ID|CHANGE_NAME> <PACKAGE_NAME>"); pw.println(" compat enable|disable|reset <CHANGE_ID|CHANGE_NAME> <PACKAGE_NAME>");
pw.println(" Toggles a change either by id or by name for <PACKAGE_NAME>."); pw.println(" Toggles a change either by id or by name for <PACKAGE_NAME>.");
pw.println(" It kills <PACKAGE_NAME> (to allow the toggle to take effect).");
pw.println(); pw.println();
Intent.printIntentArgsHelp(pw, ""); Intent.printIntentArgsHelp(pw, "");
} }