From 9fd5ca2aacd16e8ef46d0bd8b2c075ded1e98f50 Mon Sep 17 00:00:00 2001 From: Julia Reynolds Date: Mon, 3 Apr 2023 10:47:49 -0400 Subject: [PATCH] Fix notif info icons - Better ripple - Better colors Test: view icons with diff themes and display densities Fixes: 233914273 Fixes: 233900934 Change-Id: I57e4c285b2ef37f46336224f09776fbf1f97291f --- .../res/layout/notification_conversation_info.xml | 6 +++--- packages/SystemUI/res/layout/notification_info.xml | 8 ++++---- .../SystemUI/res/layout/partial_conversation_info.xml | 6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/SystemUI/res/layout/notification_conversation_info.xml b/packages/SystemUI/res/layout/notification_conversation_info.xml index 79948da978d70..4f6e88c2266f7 100644 --- a/packages/SystemUI/res/layout/notification_conversation_info.xml +++ b/packages/SystemUI/res/layout/notification_conversation_info.xml @@ -170,11 +170,11 @@ android:layout_width="@dimen/notification_importance_toggle_size" android:layout_height="@dimen/notification_importance_toggle_size" android:layout_centerVertical="true" - android:background="@drawable/ripple_drawable" android:contentDescription="@string/notification_more_settings" + android:background="@drawable/ripple_drawable_20dp" android:src="@drawable/ic_settings" - android:layout_alignParentEnd="true" - android:tint="@color/notification_guts_link_icon_tint"/> + android:tint="?android:attr/colorAccent" + android:layout_alignParentEnd="true" /> diff --git a/packages/SystemUI/res/layout/notification_info.xml b/packages/SystemUI/res/layout/notification_info.xml index 4d6c2022c3b86..852db1b8fb910 100644 --- a/packages/SystemUI/res/layout/notification_info.xml +++ b/packages/SystemUI/res/layout/notification_info.xml @@ -108,11 +108,11 @@ asked for it --> android:layout_width="@dimen/notification_importance_toggle_size" android:layout_height="@dimen/notification_importance_toggle_size" android:layout_centerVertical="true" - android:background="@android:color/transparent" android:contentDescription="@string/notification_more_settings" - android:src="@drawable/notif_settings_button" - android:layout_alignParentEnd="true" - android:tint="@color/notification_guts_link_icon_tint"/> + android:background="@drawable/ripple_drawable_20dp" + android:src="@drawable/ic_settings" + android:tint="?android:attr/colorAccent" + android:layout_alignParentEnd="true" /> diff --git a/packages/SystemUI/res/layout/partial_conversation_info.xml b/packages/SystemUI/res/layout/partial_conversation_info.xml index 9ed3f92a7d74a..4850b35833e5f 100644 --- a/packages/SystemUI/res/layout/partial_conversation_info.xml +++ b/packages/SystemUI/res/layout/partial_conversation_info.xml @@ -81,11 +81,11 @@ android:layout_width="@dimen/notification_importance_toggle_size" android:layout_height="@dimen/notification_importance_toggle_size" android:layout_centerVertical="true" - android:background="@drawable/ripple_drawable" android:contentDescription="@string/notification_more_settings" + android:background="@drawable/ripple_drawable_20dp" android:src="@drawable/ic_settings" - android:layout_alignParentEnd="true" - android:tint="@color/notification_guts_link_icon_tint"/> + android:tint="?android:attr/colorAccent" + android:layout_alignParentEnd="true"/>