From 82d3041f30818c605cca2a41861a77d58aafae3c Mon Sep 17 00:00:00 2001 From: Amith Yamasani Date: Wed, 6 Jun 2018 10:48:03 -0700 Subject: [PATCH] DO NOT MERGE Fix security exception due to incorrect flags Caught by test UsageStatsTest due to stricter checks for MATCH_ANY_USER. Change-Id: Ie884c7007a8588a222773fba8d7967bcdf2a528a Fixes: 109700742 Test: atest CtsUsageStatsTestCases:UsageStatsTest --- .../usage/java/com/android/server/usage/UsageStatsService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/usage/java/com/android/server/usage/UsageStatsService.java b/services/usage/java/com/android/server/usage/UsageStatsService.java index a7d3f78c66f04..e6584c51ebd69 100644 --- a/services/usage/java/com/android/server/usage/UsageStatsService.java +++ b/services/usage/java/com/android/server/usage/UsageStatsService.java @@ -710,7 +710,7 @@ public class UsageStatsService extends SystemService implements final int callingUid = Binder.getCallingUid(); final int callingUserId = UserHandle.getUserId(callingUid); - if (mPackageManagerInternal.getPackageUid(pkg, PackageManager.MATCH_ANY_USER, + if (mPackageManagerInternal.getPackageUid(pkg, /*flags=*/ 0, callingUserId) != callingUid) { throw new SecurityException("Calling uid " + pkg + " cannot query events" + "for package " + pkg);