From c85d6c2588e2a2b5dbdfa12927403efe98c87910 Mon Sep 17 00:00:00 2001 From: Salvador Martinez Date: Thu, 28 Mar 2019 19:15:57 -0700 Subject: [PATCH] Switch keyboard shortcuts helper to daynight theme This one was hardcoded to use light theme, switch it to daynight so that it switches properly in dark theme. Also the text colors were hardcoded so I fixed that as well. Test: visual inspection Bug: 114520166 Change-Id: Ic4789d0dfec7a7af4a49b37909ee0827ea1554bc --- packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml | 2 +- packages/SystemUI/res/values/colors.xml | 1 - .../src/com/android/systemui/statusbar/KeyboardShortcuts.java | 3 ++- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml b/packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml index d49aff9abc019..3786812db8275 100644 --- a/packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml +++ b/packages/SystemUI/res/layout/keyboard_shortcut_app_item.xml @@ -39,7 +39,7 @@ android:layout_height="wrap_content" android:paddingEnd="12dp" android:paddingBottom="4dp" - android:textColor="@color/ksh_keyword_color" + android:textColor="?android:attr/textColorPrimary" android:textSize="16sp" android:maxLines="5" android:singleLine="false" diff --git a/packages/SystemUI/res/values/colors.xml b/packages/SystemUI/res/values/colors.xml index b82c250e2bd25..290d75b4de9c1 100644 --- a/packages/SystemUI/res/values/colors.xml +++ b/packages/SystemUI/res/values/colors.xml @@ -129,7 +129,6 @@ #fff44336 - #d9000000 @color/material_grey_600 @color/material_grey_100 diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcuts.java b/packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcuts.java index 7f39e474f6c6d..7e6ddcfea7620 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcuts.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/KeyboardShortcuts.java @@ -128,7 +128,8 @@ public final class KeyboardShortcuts { private KeyCharacterMap mBackupKeyCharacterMap; private KeyboardShortcuts(Context context) { - this.mContext = new ContextThemeWrapper(context, android.R.style.Theme_DeviceDefault_Light); + this.mContext = new ContextThemeWrapper( + context, android.R.style.Theme_DeviceDefault_Settings); this.mPackageManager = AppGlobals.getPackageManager(); loadResources(context); }