Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "fix mmap leak of graphicsstats service"

Browse Source
This commit is contained in:
Treehugger Robot
2019-01-08 05:03:47 +00:00
committed by Gerrit Code Review
parent f6209cf0dd 4832438c3a
commit 9ebc299b73
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/hwui/service/GraphicsStatsService.cpp
View File

@@ -139,6 +139,7 @@ bool GraphicsStatsService::parseFromFile(const std::string& path,
uint32_t file_version = *reinterpret_cast<uint32_t*>(addr); uint32_t file_version = *reinterpret_cast<uint32_t*>(addr);
if (file_version != sCurrentFileVersion) { if (file_version != sCurrentFileVersion) {
ALOGW("file_version mismatch! expected %d got %d", sCurrentFileVersion, file_version); ALOGW("file_version mismatch! expected %d got %d", sCurrentFileVersion, file_version);
munmap(addr, sb.st_size);
return false; return false;
} }
@@ -150,6 +151,7 @@ bool GraphicsStatsService::parseFromFile(const std::string& path,
ALOGW("Parse failed on '%s' error='%s'", path.c_str(), ALOGW("Parse failed on '%s' error='%s'", path.c_str(),
output->InitializationErrorString().c_str()); output->InitializationErrorString().c_str());
} }
munmap(addr, sb.st_size);
return success; return success;
} }