From 3496fdbd2f84de3c8e8070be7d669b94ea1ca769 Mon Sep 17 00:00:00 2001 From: Narayan Kamath Date: Tue, 10 May 2016 14:24:45 +0100 Subject: [PATCH] Patrially revert 4ec026930bfbbb5d8923f359c8. In preparation for using MetricsLogger.histogram / count. The main purpose of this change is to remove the (now bogus) action IDs associated with this logging. bug: 28528058 bug: 28544474 Change-Id: Id79de2d34c3f937a327ac21d44e55c18047bce85 --- proto/src/metrics_constants.proto | 15 --------------- .../android/server/pm/PackageManagerService.java | 13 +------------ 2 files changed, 1 insertion(+), 27 deletions(-) diff --git a/proto/src/metrics_constants.proto b/proto/src/metrics_constants.proto index fd4c71e12fb27..c417fe8ae5cc6 100644 --- a/proto/src/metrics_constants.proto +++ b/proto/src/metrics_constants.proto @@ -2191,21 +2191,6 @@ message MetricsEvent { // CATEGORY: SETTINGS ACCOUNTS_WORK_PROFILE_SETTINGS = 401; - // The number of packages optimized during the optimizing apps dialog. - OPTIMIZING_APPS_NUM_PKGS_DEXOPTED = 402; - - // The number of packages which did not need optimizing during the optimizing apps dialog. - OPTIMIZING_APPS_NUM_PKGS_SKIPPED = 403; - - // The number of packages which failed to optimize during the optimizing apps dialog. - OPTIMIZING_APPS_NUM_PKGS_FAILED = 404; - - // The number of optimizable packages in the system. - OPTIMIZING_APPS_NUM_PKGS_TOTAL = 405; - - // The total amount of time the user was blocked on the optimizing apps dialog. - OPTIMIZING_APPS_TOTAL_TIME_MS = 406; - // Add new aosp constants above this line. // END OF AOSP CONSTANTS } diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java index d268e8543f6b1..2f83ec4cc299a 100644 --- a/services/core/java/com/android/server/pm/PackageManagerService.java +++ b/services/core/java/com/android/server/pm/PackageManagerService.java @@ -226,8 +226,6 @@ import com.android.internal.app.IMediaContainerService; import com.android.internal.app.ResolverActivity; import com.android.internal.content.NativeLibraryHelper; import com.android.internal.content.PackageHelper; -import com.android.internal.logging.MetricsLogger; -import com.android.internal.logging.MetricsProto.MetricsEvent; import com.android.internal.os.IParcelFileDescriptorFactory; import com.android.internal.os.InstallerConnection.InstallerException; import com.android.internal.os.SomeArgs; @@ -7223,16 +7221,7 @@ public class PackageManagerService extends IPackageManager.Stub { } final int elapsedTime = (int) TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startTime); - MetricsLogger.action(mContext, - MetricsEvent.OPTIMIZING_APPS_NUM_PKGS_DEXOPTED, numberOfPackagesOptimized); - MetricsLogger.action(mContext, - MetricsEvent.OPTIMIZING_APPS_NUM_PKGS_SKIPPED, numberOfPackagesSkipped); - MetricsLogger.action(mContext, - MetricsEvent.OPTIMIZING_APPS_NUM_PKGS_FAILED, numberOfPackagesFailed); - MetricsLogger.action(mContext, - MetricsEvent.OPTIMIZING_APPS_NUM_PKGS_TOTAL, getOptimizablePackages().size()); - MetricsLogger.action(mContext, - MetricsEvent.OPTIMIZING_APPS_TOTAL_TIME_MS, elapsedTime); + // TODO: Log events using MetricsLogger.histogram / MetricsLogger.count } @Override