From 9bca4793a33d2714b306d69ceb870925a588fe71 Mon Sep 17 00:00:00 2001 From: Romain Guy Date: Mon, 25 Oct 2010 18:42:25 -0700 Subject: [PATCH] Small cleanup. Removes unnecessary forward class declaration, make Caches::currentBuffer private instead of public. Change-Id: Idba6325c8c602d89239e667cb8ec87e7943f8e75 --- libs/hwui/Caches.cpp | 10 +++++----- libs/hwui/Caches.h | 5 +++-- libs/hwui/Patch.cpp | 2 -- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/libs/hwui/Caches.cpp b/libs/hwui/Caches.cpp index a4def0ba78b45..e0094d8245dbc 100644 --- a/libs/hwui/Caches.cpp +++ b/libs/hwui/Caches.cpp @@ -43,7 +43,7 @@ Caches::Caches(): Singleton(), blend(false), lastSrcMode(GL_ZERO), glBindBuffer(GL_ARRAY_BUFFER, meshBuffer); glBufferData(GL_ARRAY_BUFFER, sizeof(gMeshVertices), gMeshVertices, GL_STATIC_DRAW); - currentBuffer = meshBuffer; + mCurrentBuffer = meshBuffer; } /** @@ -57,9 +57,9 @@ void Caches::bindMeshBuffer() { * Binds the specified VBO. */ void Caches::bindMeshBuffer(const GLuint buffer) { - if (currentBuffer != buffer) { + if (mCurrentBuffer != buffer) { glBindBuffer(GL_ARRAY_BUFFER, buffer); - currentBuffer = buffer; + mCurrentBuffer = buffer; } } @@ -67,9 +67,9 @@ void Caches::bindMeshBuffer(const GLuint buffer) { * Unbinds the VBO used to render simple textured quads. */ void Caches::unbindMeshBuffer() { - if (currentBuffer) { + if (mCurrentBuffer) { glBindBuffer(GL_ARRAY_BUFFER, 0); - currentBuffer = 0; + mCurrentBuffer = 0; } } diff --git a/libs/hwui/Caches.h b/libs/hwui/Caches.h index 79644a55d0bfc..aff536620daa8 100644 --- a/libs/hwui/Caches.h +++ b/libs/hwui/Caches.h @@ -79,7 +79,9 @@ class Caches: public Singleton { friend class Singleton; - CacheLogger logger; + CacheLogger mlogger; + + GLuint mCurrentBuffer; public: void bindMeshBuffer(); @@ -92,7 +94,6 @@ public: Program* currentProgram; GLuint meshBuffer; - GLuint currentBuffer; TextureCache textureCache; LayerCache layerCache; diff --git a/libs/hwui/Patch.cpp b/libs/hwui/Patch.cpp index 253a19ba77ff8..3d21431bfd8d7 100644 --- a/libs/hwui/Patch.cpp +++ b/libs/hwui/Patch.cpp @@ -26,8 +26,6 @@ namespace android { namespace uirenderer { -class Caches; - /////////////////////////////////////////////////////////////////////////////// // Constructors/destructor ///////////////////////////////////////////////////////////////////////////////