Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Ensure CallId is not null when connection creation is complete." into oc-mr1-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2017-08-14 18:49:14 +00:00
committed by Android (Google) Code Review
parent a2991d045d 9a351ca849
commit 9ad54229f5
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
telecomm/java/android/telecom/ConnectionService.java
View File

@@ -1440,6 +1440,12 @@ public abstract class ConnectionService extends Service {
*/
private void notifyCreateConnectionComplete(final String callId) {
Log.i(this, "notifyCreateConnectionComplete %s", callId);
if (callId == null) {
// This could happen if the connection fails quickly and is removed from the
// ConnectionService before Telecom sends the create connection complete callback.
Log.w(this, "notifyCreateConnectionComplete: callId is null.");
return;
}
onCreateConnectionComplete(findConnectionForAction(callId,
"notifyCreateConnectionComplete"));
}
@@ -2166,7 +2172,7 @@ public abstract class ConnectionService extends Service {
}
private Connection findConnectionForAction(String callId, String action) {
if (mConnectionById.containsKey(callId)) {
if (callId != null && mConnectionById.containsKey(callId)) {
return mConnectionById.get(callId);
}
Log.w(this, "%s - Cannot find Connection %s", action, callId);