Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix finishing activity in non-focused stack

Browse Source 
This CL explicitly checks if we're finishing activity in non-focused
stack as there are other cases except this one when we finish paused
activities in FINISH_AFTER_VISIBLE mode.

Bug: 29007436
Bug: 29458854
Change-Id: I67744d23cd72f2fe8861180008bfdd284a7b5e26
This commit is contained in:
Andrii Kulian
2016-07-29 12:55:41 -07:00
parent 8960c82dcd
commit 995fa2bd2d
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
services/core/java/com/android/server/am/ActivityStack.java
View File

@@ -3559,19 +3559,22 @@ final class ActivityStack {
final ActivityState prevState = r.state; final ActivityState prevState = r.state;
if (DEBUG_STATES) Slog.v(TAG_STATES, "Moving to FINISHING: " + r); if (DEBUG_STATES) Slog.v(TAG_STATES, "Moving to FINISHING: " + r);
r.state = ActivityState.FINISHING; r.state = ActivityState.FINISHING;
final boolean finishingActivityInNonFocusedStack
= r.task.stack != mStackSupervisor.getFocusedStack()
&& prevState == ActivityState.PAUSED && mode == FINISH_AFTER_VISIBLE;
if (mode == FINISH_IMMEDIATELY if (mode == FINISH_IMMEDIATELY
|| (prevState == ActivityState.PAUSED || (prevState == ActivityState.PAUSED
&& (mode == FINISH_AFTER_PAUSE || mode == FINISH_AFTER_VISIBLE && (mode == FINISH_AFTER_PAUSE || mStackId == PINNED_STACK_ID))
|| mStackId == PINNED_STACK_ID)) || finishingActivityInNonFocusedStack
|| prevState == ActivityState.STOPPED || prevState == ActivityState.STOPPED
|| prevState == ActivityState.INITIALIZING) { || prevState == ActivityState.INITIALIZING) {
r.makeFinishingLocked(); r.makeFinishingLocked();
boolean activityRemoved = destroyActivityLocked(r, true, "finish-imm"); boolean activityRemoved = destroyActivityLocked(r, true, "finish-imm");
if (prevState == ActivityState.PAUSED && mode == FINISH_AFTER_VISIBLE) { if (finishingActivityInNonFocusedStack) {
// Finishing activity that was in paused state - this can happen if it was in // Finishing activity that was in paused state and it was in not currently focused
// not currently focused stack. Need to make something visible in its place. // stack, need to make something visible in its place.
mStackSupervisor.ensureActivitiesVisibleLocked(null, 0, !PRESERVE_WINDOWS); mStackSupervisor.ensureActivitiesVisibleLocked(null, 0, !PRESERVE_WINDOWS);
} }
if (activityRemoved) { if (activityRemoved) {