From b0c7c914eb7ee6ac134beb69bddf2c4791cca410 Mon Sep 17 00:00:00 2001 From: Narayan Kamath Date: Mon, 9 Dec 2013 11:09:21 +0000 Subject: [PATCH] Fix inconsistency in LoggingPrintStream. LoggingPrintStream prints "null" for null strings from print(String) but throws an NPE from println(String). Fix this by delegating to the underlying builder (and avoiding the "fast" path when the input String == null) bug: https://code.google.com/p/android/issues/detail?id=63380 Change-Id: I89c5c12db6ed5af8037d46f67369b38c5b4cbc9f --- core/java/com/android/internal/os/LoggingPrintStream.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/com/android/internal/os/LoggingPrintStream.java b/core/java/com/android/internal/os/LoggingPrintStream.java index 451340b463ef5..f14394ad09ce8 100644 --- a/core/java/com/android/internal/os/LoggingPrintStream.java +++ b/core/java/com/android/internal/os/LoggingPrintStream.java @@ -293,7 +293,7 @@ abstract class LoggingPrintStream extends PrintStream { @Override public synchronized void println(String s) { - if (builder.length() == 0) { + if (builder.length() == 0 && s != null) { // Optimization for a simple println. int length = s.length();