From 9892718663be17e00cc20e82d75a532161bcd613 Mon Sep 17 00:00:00 2001 From: Jonathan Basseri Date: Thu, 23 Apr 2015 23:34:15 -0700 Subject: [PATCH] Never return a reference to sDefaults. Final static fields in Java are still mutable, so CarrierConfigManager should not give callers the opportunity to mutate them. Change-Id: I413597fc5f59c249997967bb0aad2d09b54fa613 --- telephony/java/android/telephony/CarrierConfigManager.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/telephony/java/android/telephony/CarrierConfigManager.java b/telephony/java/android/telephony/CarrierConfigManager.java index 7d1a2fa9527e2..831a194605250 100644 --- a/telephony/java/android/telephony/CarrierConfigManager.java +++ b/telephony/java/android/telephony/CarrierConfigManager.java @@ -208,13 +208,13 @@ public class CarrierConfigManager { } /** - * Returns a bundle with the default value for every supported configuration variable. + * Returns a new bundle with the default value for every supported configuration variable. * * @hide */ @SystemApi public static Bundle getDefaultConfig() { - return sDefaults; + return new Bundle(sDefaults); } /** @hide */