From 2973c423b236735c548f37626815beea33326f81 Mon Sep 17 00:00:00 2001 From: Tsung-Mao Fang Date: Fri, 12 Mar 2021 16:18:59 +0800 Subject: [PATCH] Only display single line for title MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a malicious device admin app’s name includes a bunch of CRLF characters, it will cause incorrect shows and selection confusion in Settings Device admin apps listView. Test: Built the apk and saw single line title. Bug: 169936038 Change-Id: I0c9d80273ed752c5a83afcad18d67400bcfc1618 --- .../src/com/android/settingslib/widget/AppSwitchPreference.java | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/SettingsLib/AppPreference/src/com/android/settingslib/widget/AppSwitchPreference.java b/packages/SettingsLib/AppPreference/src/com/android/settingslib/widget/AppSwitchPreference.java index 781bfcdbc75e9..1ccf4175bac5a 100644 --- a/packages/SettingsLib/AppPreference/src/com/android/settingslib/widget/AppSwitchPreference.java +++ b/packages/SettingsLib/AppPreference/src/com/android/settingslib/widget/AppSwitchPreference.java @@ -51,6 +51,7 @@ public class AppSwitchPreference extends SwitchPreference { @Override public void onBindViewHolder(PreferenceViewHolder holder) { + setSingleLineTitle(true); super.onBindViewHolder(holder); final View switchView = holder.findViewById(android.R.id.switch_widget); if (switchView != null) {