Merge "Links WPP clocks flag to SysUI's flag (3/3)." into tm-qpr-dev

This commit is contained in:
Ale Nijamkin
2022-12-16 20:04:46 +00:00
committed by Android (Google) Code Review
4 changed files with 16 additions and 5 deletions

View File

@@ -58,7 +58,9 @@ class FakeKeyguardQuickAffordanceProviderClient(
flags: List<KeyguardQuickAffordanceProviderClient.Flag> = flags: List<KeyguardQuickAffordanceProviderClient.Flag> =
listOf( listOf(
KeyguardQuickAffordanceProviderClient.Flag( KeyguardQuickAffordanceProviderClient.Flag(
name = KeyguardQuickAffordanceProviderContract.FlagsTable.FLAG_NAME_FEATURE_ENABLED, name =
KeyguardQuickAffordanceProviderContract.FlagsTable
.FLAG_NAME_CUSTOM_LOCK_SCREEN_QUICK_AFFORDANCES_ENABLED,
value = true, value = true,
) )
), ),

View File

@@ -148,7 +148,11 @@ object KeyguardQuickAffordanceProviderContract {
/** /**
* Flag denoting whether the customizable lock screen quick affordances feature is enabled. * Flag denoting whether the customizable lock screen quick affordances feature is enabled.
*/ */
const val FLAG_NAME_FEATURE_ENABLED = "is_feature_enabled" const val FLAG_NAME_CUSTOM_LOCK_SCREEN_QUICK_AFFORDANCES_ENABLED =
"is_custom_lock_screen_quick_affordances_feature_enabled"
/** Flag denoting whether the customizable clocks feature is enabled. */
const val FLAG_NAME_CUSTOM_CLOCKS_ENABLED = "is_custom_clocks_feature_enabled"
object Columns { object Columns {
/** String. Unique ID for the flag. */ /** String. Unique ID for the flag. */

View File

@@ -34,7 +34,7 @@ import com.android.systemui.keyguard.shared.model.KeyguardSlotPickerRepresentati
import com.android.systemui.keyguard.shared.quickaffordance.KeyguardQuickAffordancePosition import com.android.systemui.keyguard.shared.quickaffordance.KeyguardQuickAffordancePosition
import com.android.systemui.plugins.ActivityStarter import com.android.systemui.plugins.ActivityStarter
import com.android.systemui.settings.UserTracker import com.android.systemui.settings.UserTracker
import com.android.systemui.shared.quickaffordance.data.content.KeyguardQuickAffordanceProviderContract import com.android.systemui.shared.quickaffordance.data.content.KeyguardQuickAffordanceProviderContract as Contract
import com.android.systemui.statusbar.policy.KeyguardStateController import com.android.systemui.statusbar.policy.KeyguardStateController
import dagger.Lazy import dagger.Lazy
import javax.inject.Inject import javax.inject.Inject
@@ -333,9 +333,13 @@ constructor(
fun getPickerFlags(): List<KeyguardPickerFlag> { fun getPickerFlags(): List<KeyguardPickerFlag> {
return listOf( return listOf(
KeyguardPickerFlag( KeyguardPickerFlag(
name = KeyguardQuickAffordanceProviderContract.FlagsTable.FLAG_NAME_FEATURE_ENABLED, name = Contract.FlagsTable.FLAG_NAME_CUSTOM_LOCK_SCREEN_QUICK_AFFORDANCES_ENABLED,
value = featureFlags.isEnabled(Flags.CUSTOMIZABLE_LOCK_SCREEN_QUICK_AFFORDANCES), value = featureFlags.isEnabled(Flags.CUSTOMIZABLE_LOCK_SCREEN_QUICK_AFFORDANCES),
) ),
KeyguardPickerFlag(
name = Contract.FlagsTable.FLAG_NAME_CUSTOM_CLOCKS_ENABLED,
value = featureFlags.isEnabled(Flags.LOCKSCREEN_CUSTOM_CLOCKS),
),
) )
} }

View File

@@ -167,6 +167,7 @@ class KeyguardQuickAffordanceProviderTest : SysuiTestCase() {
featureFlags = featureFlags =
FakeFeatureFlags().apply { FakeFeatureFlags().apply {
set(Flags.CUSTOMIZABLE_LOCK_SCREEN_QUICK_AFFORDANCES, true) set(Flags.CUSTOMIZABLE_LOCK_SCREEN_QUICK_AFFORDANCES, true)
set(Flags.LOCKSCREEN_CUSTOM_CLOCKS, true)
}, },
repository = { quickAffordanceRepository }, repository = { quickAffordanceRepository },
) )