From 97ecc9cbe7eccafc0923d7655daf07f4c2ea9791 Mon Sep 17 00:00:00 2001 From: Wei Huang Date: Mon, 11 May 2009 17:44:20 -0700 Subject: [PATCH] define Intent.ACTION_REMOTE_INTENT, which replaces the old GTalk data messaging intent "android.intent.action.GTALK_DATA_MESSAGE_RECEIVED". The remote intent concept shouldn't be limited to Google or GTalkService. It should be owned by the Android platform. --- api/current.xml | 22 +++++++++++++++++++ core/java/android/content/Intent.java | 22 +++++++++++++++++++ core/res/AndroidManifest.xml | 2 +- .../AndroidManifest.xml | 2 +- .../SubscribedFeedsIntentService.java | 8 +++---- .../android/server/MasterClearReceiver.java | 4 ++-- 6 files changed, 52 insertions(+), 8 deletions(-) diff --git a/api/current.xml b/api/current.xml index 36670aa2d39dd..95fbea9bb4581 100644 --- a/api/current.xml +++ b/api/current.xml @@ -31502,6 +31502,17 @@ visibility="public" > + + + + - + diff --git a/packages/SubscribedFeedsProvider/AndroidManifest.xml b/packages/SubscribedFeedsProvider/AndroidManifest.xml index 6ecda48a7cb54..c254d9391087a 100644 --- a/packages/SubscribedFeedsProvider/AndroidManifest.xml +++ b/packages/SubscribedFeedsProvider/AndroidManifest.xml @@ -19,7 +19,7 @@ android:writePermission="android.permission.SUBSCRIBED_FEEDS_WRITE" /> - + diff --git a/packages/SubscribedFeedsProvider/src/com/android/providers/subscribedfeeds/SubscribedFeedsIntentService.java b/packages/SubscribedFeedsProvider/src/com/android/providers/subscribedfeeds/SubscribedFeedsIntentService.java index 0d05286bdc6ef..2326b46f38cc7 100644 --- a/packages/SubscribedFeedsProvider/src/com/android/providers/subscribedfeeds/SubscribedFeedsIntentService.java +++ b/packages/SubscribedFeedsProvider/src/com/android/providers/subscribedfeeds/SubscribedFeedsIntentService.java @@ -43,8 +43,7 @@ public class SubscribedFeedsIntentService extends IntentService { private static final String sSubscribedFeedsPrefs = "subscribedFeeds"; - private static final String GTALK_DATA_MESSAGE_RECEIVED = - "android.intent.action.GTALK_DATA_MESSAGE_RECEIVED"; + private static final String REMOTE_INTENT_ACTION = Intent.ACTION_REMOTE_INTENT; private static final String SUBSCRIBED_FEEDS_REFRESH_ACTION = "com.android.subscribedfeeds.action.REFRESH"; @@ -56,8 +55,9 @@ public class SubscribedFeedsIntentService extends IntentService { } protected void onHandleIntent(Intent intent) { - if (GTALK_DATA_MESSAGE_RECEIVED.equals(intent.getAction())) { - boolean fromTrustedServer = intent.getBooleanExtra("from_trusted_server", false); + if (REMOTE_INTENT_ACTION.equals(intent.getAction())) { + boolean fromTrustedServer = intent.getBooleanExtra( + "android.intent.extra.from_trusted_server", false); if (fromTrustedServer) { String accountName = intent.getStringExtra("account"); String token = intent.getStringExtra("message_token"); diff --git a/services/java/com/android/server/MasterClearReceiver.java b/services/java/com/android/server/MasterClearReceiver.java index 5a42e767cfc7f..3c366da9a3b04 100644 --- a/services/java/com/android/server/MasterClearReceiver.java +++ b/services/java/com/android/server/MasterClearReceiver.java @@ -30,8 +30,8 @@ public class MasterClearReceiver extends BroadcastReceiver { @Override public void onReceive(Context context, Intent intent) { - if (intent.getAction().equals("android.intent.action.GTALK_DATA_MESSAGE_RECEIVED")) { - if (!intent.getBooleanExtra("from_trusted_server", false)) { + if (intent.getAction().equals(Intent.ACTION_REMOTE_INTENT)) { + if (!intent.getBooleanExtra("android.intent.extra.from_trusted_server", false)) { Log.w(TAG, "Ignoring master clear request -- not from trusted server."); return; }