From 7a980119f638422dd6c864d3f12874128f2aa57f Mon Sep 17 00:00:00 2001 From: Aaron Liu Date: Tue, 24 May 2022 19:29:02 +0000 Subject: [PATCH] [Bouncer] Move reset logic to end event. Move reset logic to end event. Looking at the logs, we see OpenGLRenderer: endAllStagingAnimators on 0xb40000779658e860 (KeyguardPINView) We are still seeing the pin pad is disappearing. It's likely that we need to capture the end event. Bug: 228886154 Test: Manual on device Change-Id: Ife8683c1e1668924859da3b648c5211a44ed7e7c --- .../animation/AppearAnimationUtils.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/SettingsLib/src/com/android/settingslib/animation/AppearAnimationUtils.java b/packages/SettingsLib/src/com/android/settingslib/animation/AppearAnimationUtils.java index b066d85f147c2..da74162082c7c 100644 --- a/packages/SettingsLib/src/com/android/settingslib/animation/AppearAnimationUtils.java +++ b/packages/SettingsLib/src/com/android/settingslib/animation/AppearAnimationUtils.java @@ -216,22 +216,16 @@ public class AppearAnimationUtils implements AppearAnimationCreator { }); } alphaAnim.addListener(new AnimatorListenerAdapter() { - @Override - public void onAnimationCancel(Animator animation) { - // If Animation is canceled, we want to ensure UI is reset. - view.setAlpha(targetAlpha); - view.setTranslationY(targetTranslationY); - } - @Override public void onAnimationEnd(Animator animation) { + view.setAlpha(targetAlpha); if (endRunnable != null) { endRunnable.run(); } } }); alphaAnim.start(); - startTranslationYAnimation(view, delay, duration, appearing ? 0 : translationY, + startTranslationYAnimation(view, delay, duration, targetTranslationY, interpolator, animatorListener); } } @@ -265,6 +259,12 @@ public class AppearAnimationUtils implements AppearAnimationCreator { if (listener != null) { translationAnim.addListener(listener); } + translationAnim.addListener(new AnimatorListenerAdapter() { + @Override + public void onAnimationEnd(Animator animation) { + view.setTranslationY(endTranslationY); + } + }); translationAnim.start(); }