From b8d572eb86a24718002d51fa856823f8ad5ab2a5 Mon Sep 17 00:00:00 2001 From: Felipe Leme Date: Mon, 5 Dec 2016 13:41:43 -0800 Subject: [PATCH] Fixed Mockito expectation. Bug: 33349775 Test: most tests from NetworkPolicyManagerServiceTest passes (there are still 3 failures, but they're unrelated). Change-Id: I291a2d8404ba540d9922e5de62f5224d2d9b9314 --- .../server/NetworkPolicyManagerServiceTest.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/services/tests/servicestests/src/com/android/server/NetworkPolicyManagerServiceTest.java b/services/tests/servicestests/src/com/android/server/NetworkPolicyManagerServiceTest.java index 3114f3fc2b265..ab38e43245b59 100644 --- a/services/tests/servicestests/src/com/android/server/NetworkPolicyManagerServiceTest.java +++ b/services/tests/servicestests/src/com/android/server/NetworkPolicyManagerServiceTest.java @@ -49,6 +49,7 @@ import static org.mockito.Matchers.anyLong; import static org.mockito.Matchers.anyString; import static org.mockito.Matchers.eq; import static org.mockito.Matchers.isA; +import static org.mockito.Matchers.isNull; import static org.mockito.Mockito.atLeastOnce; import static org.mockito.Mockito.doAnswer; import static org.mockito.Mockito.mock; @@ -141,6 +142,15 @@ import java.util.stream.Collectors; /** * Tests for {@link NetworkPolicyManagerService}. + * + *

Typical usage: + * + *


+    m -j32 FrameworksServicesTests && adb install -r -g \
+    ${ANDROID_PRODUCT_OUT}/data/app/FrameworksServicesTests/FrameworksServicesTests.apk && \
+    adb shell am instrument -e class "com.android.server.NetworkPolicyManagerServiceTest" -w \
+    "com.android.frameworks.servicestests/android.support.test.runner.AndroidJUnitRunner"
+ * 
*/ @RunWith(AndroidJUnit4.class) @MediumTest @@ -247,7 +257,7 @@ public class NetworkPolicyManagerServiceTest { return null; } }).when(mActivityManager).registerUidObserver(any(), anyInt(), - ActivityManager.PROCESS_STATE_UNKNOWN, null); + eq(ActivityManager.PROCESS_STATE_UNKNOWN), isNull(String.class)); mService = new NetworkPolicyManagerService(mServiceContext, mActivityManager, mStatsService, mNetworkManager, mIpm, mTime, mPolicyDir, true);