From a1c3f60121762a349e802011c764ebaa3b019b1b Mon Sep 17 00:00:00 2001 From: Riddle Hsu Date: Tue, 6 Jun 2023 14:05:22 +0000 Subject: [PATCH] Remove unnecessary invocation of updateRotation mMultiuserReceiver#onReceive will call mSettingsObserver.onChange. But both mSettingsObserver#updateSettings and mDefaultDisplayRotation.onUserSwitch() in mMultiuserReceiver#onReceive already check if there is something needs to update rotation. So it is unnecessary to call updateRotation again in mSettingsObserver.onChange. Bug: 197745994 Test: Switch user Change-Id: Ic201f319739e910bfb7bf4c9c55a9d687b35cb78 --- .../core/java/com/android/server/policy/PhoneWindowManager.java | 1 - 1 file changed, 1 deletion(-) diff --git a/services/core/java/com/android/server/policy/PhoneWindowManager.java b/services/core/java/com/android/server/policy/PhoneWindowManager.java index 2806a1176e1cd..c85cb57de5560 100644 --- a/services/core/java/com/android/server/policy/PhoneWindowManager.java +++ b/services/core/java/com/android/server/policy/PhoneWindowManager.java @@ -824,7 +824,6 @@ public class PhoneWindowManager implements WindowManagerPolicy { @Override public void onChange(boolean selfChange) { updateSettings(); - updateRotation(false); } }