Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fixed a memory leak with notification children" into nyc-dev

Browse Source
This commit is contained in:
Selim Cinek
2016-05-10 03:03:08 +00:00
committed by Android (Google) Code Review
parent 6be7049639 7103fd44a8
commit 9688c2edc9
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java
View File

@@ -1544,6 +1544,9 @@ public class PhoneStatusBar extends BaseStatusBar implements DemoMode,
} }
for (int i = 0; i < toRemove.size(); i++) { for (int i = 0; i < toRemove.size(); i++) {
removeNotification(toRemove.get(i).getStatusBarNotification().getKey(), ranking); removeNotification(toRemove.get(i).getStatusBarNotification().getKey(), ranking);
// we need to ensure that the view is actually properly removed from the viewstate
// as this won't happen anymore when kept in the parent.
mStackScroller.removeViewStateForView(toRemove.get(i));
} }
} }
} }

9
packages/SystemUI/src/com/android/systemui/statusbar/stack/NotificationStackScrollLayout.java
View File

@@ -3589,6 +3589,15 @@ public class NotificationStackScrollLayout extends ViewGroup
setFadedOut(alpha != 1.0f); setFadedOut(alpha != 1.0f);
} }
/**
* Remove the a given view from the viewstate. This is currently used when the children are
* kept in the parent artificially to have a nicer animation.
* @param view the view to remove
*/
public void removeViewStateForView(View view) {
mCurrentStackScrollState.removeViewStateForView(view);
}
/** /**
* A listener that is notified when some child locations might have changed. * A listener that is notified when some child locations might have changed.
*/ */