Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Handle the case of Preference lists that have header views inserted at the top."

Browse Source
This commit is contained in:
Amith Yamasani
2011-09-29 16:48:55 -07:00
committed by Android (Google) Code Review
parent 1e70aa94c1 2d43d283fc
commit 966222ef24
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/java/android/preference/PreferenceScreen.java
View File

@@ -26,6 +26,7 @@ import android.text.TextUtils;
import android.util.AttributeSet; import android.util.AttributeSet;
import android.view.View; import android.view.View;
import android.view.Window; import android.view.Window;
import android.widget.AbsListView;
import android.widget.Adapter; import android.widget.Adapter;
import android.widget.AdapterView; import android.widget.AdapterView;
import android.widget.ListAdapter; import android.widget.ListAdapter;
@@ -190,9 +191,13 @@ public final class PreferenceScreen extends PreferenceGroup implements AdapterVi
} }
public void onItemClick(AdapterView parent, View view, int position, long id) { public void onItemClick(AdapterView parent, View view, int position, long id) {
// If the list has headers, subtract them from the index.
if (parent instanceof ListView) {
position -= ((ListView) parent).getHeaderViewsCount();
}
Object item = getRootAdapter().getItem(position); Object item = getRootAdapter().getItem(position);
if (!(item instanceof Preference)) return; if (!(item instanceof Preference)) return;
final Preference preference = (Preference) item; final Preference preference = (Preference) item;
preference.performClick(this); preference.performClick(this);
} }