From 95cf4e70883d56acdb5da40052c5f77713e592e6 Mon Sep 17 00:00:00 2001 From: Boleyn Su Date: Fri, 16 Oct 2020 04:44:35 +0900 Subject: [PATCH] gpuDrawTime should default to 0 when endTime is unknown gpuDrawTime should default to 0 when endTime is unknown, otherwise we will treat nagative duration as infinity in JankTracker::finishGpuDraw. Test: atest com.android.server.cts.GraphicsStatsValidationTest#testJankyDrawFrame Bug: b/168262403 Change-Id: I4bb61074e6917ec7ef4af429f48487ae34f8ad0b --- libs/hwui/FrameInfo.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/hwui/FrameInfo.h b/libs/hwui/FrameInfo.h index d24eca7d00c6f..bb875e35f6f7d 100644 --- a/libs/hwui/FrameInfo.h +++ b/libs/hwui/FrameInfo.h @@ -158,7 +158,7 @@ public: // GPU start time is approximated to the moment before swapBuffer is invoked. // We could add an EGLSyncKHR fence at the beginning of the frame, but that is an overhead. int64_t endTime = get(FrameInfoIndex::GpuCompleted); - return endTime > 0 ? endTime - get(FrameInfoIndex::SwapBuffers) : -1; + return endTime > 0 ? endTime - get(FrameInfoIndex::SwapBuffers) : 0; } inline int64_t& set(FrameInfoIndex index) { return mFrameInfo[static_cast(index)]; }