Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash on calling removeSelection with showing selection handlers

Browse Source 
A crash occured on updating after calling removeSelection with showing
selection handlers. This was because some selection-handler code didn't
consider the case the selection index was -1 (-1 means there is no selection).
This patch fixes this crash.

Bug: 23299977
Change-Id: I736d315e073f773aec597522203015205a8da42b
This commit is contained in:
Yoshiki Iguchi
2015-10-15 13:34:41 +09:00
parent 809dcade99
commit 9582e15196
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/java/android/widget/Editor.java
View File

@@ -4253,10 +4253,14 @@ public class Editor {
positionAtCursorOffset(offset, false);
}
/**
* @param offset Cursor offset. Must be in [-1, length].
* @param parentScrolled If the parent has been scrolled or not.
*/
@Override
protected void positionAtCursorOffset(int offset, boolean parentScrolled) {
super.positionAtCursorOffset(offset, parentScrolled);
mInWord = !getWordIteratorWithText().isBoundary(offset);
mInWord = (offset != -1) && !getWordIteratorWithText().isBoundary(offset);
}
@Override
@@ -4489,10 +4493,14 @@ public class Editor {
positionAtCursorOffset(offset, false);
}
/**
* @param offset Cursor offset. Must be in [-1, length].
* @param parentScrolled If the parent has been scrolled or not.
*/
@Override
protected void positionAtCursorOffset(int offset, boolean parentScrolled) {
super.positionAtCursorOffset(offset, parentScrolled);
mInWord = !getWordIteratorWithText().isBoundary(offset);
mInWord = (offset != -1) && !getWordIteratorWithText().isBoundary(offset);
}
@Override